Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GMaps by Leaflet #6

Open
Facyla opened this issue Jul 9, 2014 · 2 comments
Open

Replace GMaps by Leaflet #6

Facyla opened this issue Jul 9, 2014 · 2 comments

Comments

@Facyla
Copy link
Member

Facyla commented Jul 9, 2014

GMaps is a pain to engage OSS communities in this project, and Leaflet, besides providing OSM maps, allows to switch easily between various map providers, so i think we should definitely switch to Leaflet...
It seems that most of the GMap related logic lies in js/poi-lib.js.

  1. Could you confirm that ?

  2. and also are the js and php libs the exact same in every template ?

If the answer is "yes" (which i hope), could prototype implementing Leaflet in this template, and we could then deploy it...

@citadel-eu
Copy link
Member

  1. poi-lib.js does indeed contain all he gmap related functions.

  2. although most of the functionality is the same, there are some differences that might/might not be affected if we switch to Leaflet. I guess if you go the way of prototyping for the parking template we can check how hard will it be to apply the changes to the other templates. Nevertheless, even if the only outcome is a modified Leaflet-based parking template, it can be a branch to have as showcase

@Facyla
Copy link
Member Author

Facyla commented Jul 15, 2014

I've given a quick try on Pois template (local dev only), and there will be a bunch of functions that need updating in poi-lib.js : there are many changes in the markers, popup formatting, etc. that require quite heavy changes in this file. That was just "for testing" so i need to dive further into the lib functions to provide Leaflet support.. Also it requires some changes in HTML files as well (some JS in index page).

So... i'll try that for the Parking template as you suggest, in a specific branch. Will keep you updated once i get some results !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants