-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ruff and configuration #1449
Conversation
tilavarauspalvelu/api/graphql/types/reservation/serializers/update_serializers.py
Outdated
Show resolved
Hide resolved
tilavarauspalvelu/management/commands/data_creation/create_reservations.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some behavioral changesthat should be looked at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
- Remove stabilized rules from `lint.extend-select`
Move all imports that can be moved into the type-checking block. Note: When there are other imports from the same module, the import circularity and performance benefits no longer apply from moving the import.
- Full change will be done in multiple commits for cleaner history
There was already some files which imported both `datetime` AND `datetime.datetime`
Quality Gate passedIssues Measures |
I'm merging this just so that I can start working on top of it. Open another PR if you need to add more changes. |
🛠️ Changelog
🧪 Test plan
🚧 Dependencies
🎫 Tickets