Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long load times for filtering #1205

Closed
emilyjablonski opened this issue Apr 28, 2022 · 3 comments
Closed

Long load times for filtering #1205

emilyjablonski opened this issue Apr 28, 2022 · 3 comments
Assignees

Comments

@emilyjablonski
Copy link
Collaborator

emilyjablonski commented Apr 28, 2022

It is inconsistent, but you can reliably experience a long load time for filtering (relatively long, but it is a few seconds when it should be almost instantaneous especially considering there are <15 listings in the tested cases).

Example repro steps:

  • Add a single unit type filter, submit
  • Add a single availability filter, submit
  • Add the verified filter, submit
    .... etc ....

Most of the time it is instantaneous, but sometimes it takes a few seconds.

https://images.zenhubusercontent.com/197330191/3bae64a7-4430-4f03-98d5-72ebceaaca2d/screen_recording_2022_04_28_at_5_25_27_pm.mov

@YazeedLoonat
Copy link
Collaborator

@emilyjablonski @seanmalbert I wasn't able to replicate this issue anymore, from request by Sean though I did do some testing using a few different criteria. It ended up looking jank in github comment, so I created: https://docs.google.com/document/d/1ociGod-_0KxbOTAeCbO6-Wq0p9tiEGgA3Dk6Xc2xStg/edit?usp=sharing

to help explain my findings. I'm not sure if any of that helps either of you, but if you have any questions or wanna talk about it lemme know

@seanmalbert
Copy link
Collaborator

seanmalbert commented May 4, 2022

@YazeedLoonat , as discussed, let's make these updates in parts:

  • Create new views as slim as they can be, one for public browse/filter pages and one for partners and update the sites to use them

  • update listings.service list to run the inner query to fetch the IDs and pass those into the main query, if there is no filter we can skip the inner filter query

  • the theory is that we now may be able to query unit groups as part of the main query, illuminating the need for the query in addUnitSummariesToListings

@kathyccheng
Copy link

Closing, remaining work in #1390 and #1391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants