Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider proxy classes #14

Open
bertday opened this issue Dec 12, 2016 · 0 comments
Open

Reconsider proxy classes #14

bertday opened this issue Dec 12, 2016 · 0 comments

Comments

@bertday
Copy link
Contributor

bertday commented Dec 12, 2016

Datum was implemented with generic proxy classes like Table and Database which wrap a more specific child object, such as a PostgresTable or OracleStgeomTable. The purpose of this was to keep the interfaces consistent (e.g. a PostgresTable could never have a method that an OracleStgeomTable didn't). There was also a (partly cosmetic) motivation to standardize the results of type checks across like objects. However, there may be scenarios where there's useful functionality for one data source that doesn't make sense in another, like getting permissions from an Oracle SDE database. It may make more sense to move towards a constructor pattern that returns more specifically-typed objects and raising NotImplemented errors if something is missing in a subclass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant