Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lore matching for ItemNames API #28

Open
Maxopoly opened this issue May 6, 2020 · 2 comments
Open

Lore matching for ItemNames API #28

Maxopoly opened this issue May 6, 2020 · 2 comments

Comments

@Maxopoly
Copy link
Member

Maxopoly commented May 6, 2020

Currently ItemNames uses Material and item name. Item name is rather useless, instead we would want to use Material and Lore. In particular I want:

  • If Item has lore, lookup based on lore. If no hit is found lookup without lore and return that as fallback

  • Special lore mappable to prefix/suffixes, which doesn't break other lookup. "Compacted Item" lore should prefix "Compacted" into the output (but that should be a config detail). Further a compacted Energizer (lored bastion component) should be recognized as such, both lore properties should be handled accordingly

@Protonull
Copy link

Very much happy to look into updating this. Are there any other use cases other than ignoring "Compacted Item"? Just wondering how extensive this system should be.

@Maxopoly
Copy link
Member Author

Maxopoly commented May 7, 2020

Just have a system of arbitrary prefixes and postifxes, which have their lore key removed during the main lookup for those.

It might also be nice to be able to define a fallback mechanic of "If any of the lore lines on the item matches the one defined in this config, match entries" to allow fallbacks for things that'd only have a few constant lines, like PrisonPearls.

okx-code pushed a commit to okx-code/CivModCore that referenced this issue Dec 27, 2020
psygate pushed a commit to psygate/CivModCore that referenced this issue Jun 14, 2022
Add scheduled task to save regular changes for SingleBlockAPIView used in JukeAlert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants