JukeAlertLogger.removeIgnoredGroup doesn't support more then 1 group

[erocs]

removeIgnoredGroup retrieves the muted groups list but then does a string compare of that list against the single group name to be removed. This means that once more then one group is muted, no group can ever be unmuted for that player.

[jjj5311]

Hmm is a confirmed bug? I remember explicitly testing this.

The group list is stored in the database as a space separated string..:

The first comparison is for if they only have one ignored group it later splits group names into a list then removes that group element and stores back in the db as a string?

[ttk2]

is looks like some user is in modmail with this problem, so I assume erocs observed its cause first hand if he made this bug report.

[jjj5311]

Can you get what was out putted to them with just running Jamute with no args?

[jjj5311]

Also is user getting any message when they attempt to unmute the group?

[erocs]

I made the issue quick to get the ball rolling so the reasoning might be
wrong. It should be easy to try out on civtest.
On Jul 8, 2015 6:46 AM, "jjj5311" [email protected] wrote:

Also is user getting any message when they attempt to unmute the group?

—
Reply to this email directly or view it on GitHub
#35 (comment).

[ttk2]

from what they reported no messages when they try to unmute.

[Langly-]

I got the "removed group from mute list" message. But never any info from the snitches, they stayed muted.

[jjj5311]

Ok that is the message I thought they should receive I will take a look
tonight

On Wednesday, July 8, 2015, Langly- [email protected] wrote:

I got the "removed group from mute list" message. But never any info from
the snitches, they stayed muted.

—
Reply to this email directly or view it on GitHub
#35 (comment).

[Langly-]

I also have the same few groups a whole bunch of times in /nllg on the first few pages, over and over, never seen that before, not sure if it's related.

[jjj5311]

I cannot seem to reproduce the bug. I think it may be related to having the same group in your list multiple times...

Once we get up to 1.8.7 everywhere i can add some logging that will help us figure out why the removal is not working

[ttk2]

How would you get the same group more than once?

[Langly-]

This is how they look with /nllg http://imgur.com/a/iBeNc the broken one isn't one that is repeated at all though.

[jjj5311]

Hmmm someone should check the database on that

On Thursday, July 9, 2015, Langly- [email protected] wrote:

This is how they look with /nllg http://imgur.com/a/iBeNc the broken one
isn't one that is repeated at all though.

—
Reply to this email directly or view it on GitHub
#35 (comment).

[rourke750]

Huh thought I fixed that. I'm guessing you merged multiple groups into
their correct?
On Jul 9, 2015 1:58 PM, "jjj5311" [email protected] wrote:

Hmmm someone should check the database on that

On Thursday, July 9, 2015, Langly- [email protected] wrote:

This is how they look with /nllg http://imgur.com/a/iBeNc the broken one
isn't one that is repeated at all though.

—
Reply to this email directly or view it on GitHub
<#35 (comment)
.

—
Reply to this email directly or view it on GitHub
#35 (comment).

[Langly-]

I never did any group merging, I had been member, then I was transfered owner on them.

[jjj5311]

@rourke750 any ideas?

[Langly-]

Update: After 1.8.7 I still couldn't unmute the group, I finally made it unmute by systematically unmuting other groups until I found the one that would unmute, then moving on to clear the muted list.

[ttk2]

where on the list was the one that worked?

[Langly-]

IIRC it was the first one on the list when just using /jamute

I just wish my snitches weren't muted the other day when for some reason my wolf left by them warped to me and I was suddenly combat tagged even though no one was around me. I'd know who had done it.

A side note, a group I've just been added to also shows in my group list many times, so what ever is going on with group merging is also derpy not sure if that makes it affect this or not. I've seen some really bizarre interactions before.

[GopherAtl]

Just to throw this out there, I'm in the group b_general1 twice, have been since I originally accepted the group invite; two separate people had sent me invites, one while I was offline and another the next day when I reconnected. I've assumed that was the reason, but I never thought to report it :shameface: and it may be coincidence, dunno.