Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /rb command to show growth rates #85

Open
Maxopoly opened this issue Aug 4, 2016 · 10 comments
Open

Add /rb command to show growth rates #85

Maxopoly opened this issue Aug 4, 2016 · 10 comments

Comments

@Maxopoly
Copy link

Maxopoly commented Aug 4, 2016

Opens GUI that shows everything important for every growable for the current biome.

@benjajaja
Copy link

@Maxopoly is jukealert a good place to look into how to do this?

@Maxopoly
Copy link
Author

Yes, JukeAlert or NameLayer

@benjajaja
Copy link

Hi @Maxopoly, for the GUI, which is awesome BTW and easy to make work, I have to extend ACivMod instead of JavaPlugin. But when I do this, the plugin suddenly won't save/load the packaged config.yml anymore (see here).
It's very weird, it only saves (to plugins/RealisticBiomes/config.yml on the server) this part:

  #---------------------------------------
# Example config using replacement, if replace_fishing: true is set
# fish_drops:
#  mat_FISH:
#   # 50% of drops will be fish, regardless of "minecraft" drops.
#   base_rate: 0.5

and nothing of the config gets loaded, no plants configured. If I remove all those commented line from the config.yml, the saved config.yml is just empty. I have been trying to figure out what part of ACivMod could interfere, but I really can't make any sense out of this. ACivMod loads another config, but I think that's just for the annotations and should not interfere with RB.

Do you have any idea what the issue could be, or where I could look further?

@Maxopoly
Copy link
Author

It's because of the stupid CivConfig stuff. It will parse the config and then write it back together with the hardcoded defaults. If it's actively deleting your config, the whole thing failed to parse, which most likely means the yaml structure is invalid (check for errors at the very beginning of the server startup log).

@benjajaja
Copy link

benjajaja commented Sep 23, 2016

The thing, without extend ACivMod, JavaPlugin will parse it just fine with its YAMLParser. Well, I will have to investigate further.
Edit: it's the default config.yml from the repo.

@Maxopoly
Copy link
Author

Did you call super.onEnable() at the start of your onEnable method?

@benjajaja
Copy link

Yes I did

El 23 sept. 2016 1:09 p. m., "Maxopoly" [email protected] escribió:

Did you call super.onEnable() at the start of your onEnable method?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#85 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAS7x4dNldVsG0Nd89V2WNjdLGlpHJAVks5qs7N1gaJpZM4JcOBK
.

@Maxopoly
Copy link
Author

I'm out of ideas then. If you push what you have somewhere I'll try to figure it out.

@benjajaja
Copy link

Ok, thanks for the help!

El 23 sept. 2016 1:16 p. m., "Maxopoly" [email protected] escribió:

I'm out of ideas then. If you push what you have somewhere I'll try to
figure it out.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#85 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAS7x460i40JjWaBmxi_mtoGuqnXchnVks5qs7UMgaJpZM4JcOBK
.

@benjajaja
Copy link

I ended up not inheriting ACivMod and just registering the inventory-menu listener to make it work.

@benjajaja benjajaja self-assigned this Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants