Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

CP Version and PHP Version Warnings #108

Open
ghost opened this issue Jun 6, 2023 · 2 comments
Open

CP Version and PHP Version Warnings #108

ghost opened this issue Jun 6, 2023 · 2 comments
Labels
status: needs triage This issue needs revision, splitting, or other gardening work type: bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jun 6, 2023

Expected behavior

The expected behavior is when a theme or plugin when a specific version is set for example Requires PHP: 8.0, it should throw an error or warning stating that the theme does not work with your version of PHP or Requires CP: 1.4.0
Screenshot 2023-06-06 at 7 31 15 AM

Current behavior

The current behavior just doesn't give any errors or warnings if a theme or plugin has set these requirements. Please note that the issue occurs in 1.5.3 so I don't know if Version 2 have the same issue or not since I haven't tried CP 2.0.

Possible solution

create a function or modify the code to use version_compare()

Steps to reproduce bug

  1. Change Requires PHP or Requires CP for something higher or lower depending on the Header.

Context

No response

ClassicPress version

1.5.3

PHP version

7.3

Can you help?

I can help test a solution

@ghost ghost added status: needs triage This issue needs revision, splitting, or other gardening work type: bug Something isn't working labels Jun 6, 2023
@xxsimoxx
Copy link
Member

xxsimoxx commented Jun 7, 2023

ClassicPress v. 2 is currently checking for PHP version.

image

@ghost
Copy link
Author

ghost commented Jun 11, 2023

how bout CP version.. just in case if a theme doesn't match the requirements.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: needs triage This issue needs revision, splitting, or other gardening work type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant