Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

🐞 ... causes problems with classic-SEO using php 8.1 ... #139

Closed
Soenke2 opened this issue Jul 4, 2023 · 19 comments
Closed

🐞 ... causes problems with classic-SEO using php 8.1 ... #139

Soenke2 opened this issue Jul 4, 2023 · 19 comments

Comments

@Soenke2
Copy link

Soenke2 commented Jul 4, 2023

Expected behavior

Hallo,

I'm not sure, if it is helpful, ...

but I was curious to try v2.

Everything works using 8.0 ..., only error messages using php 8.1.

... only causes problems with classic-SEO using php 8.1, not with ... 8.0 ...

Deprecated: Calling static trait method Classic_SEO\Helpers\Conditional::is_heartbeat is deprecated, it should only be called on a class using the trait in /homepages.../wp-content/plugins/classicpress-seo/includes/module/class-manager.php on line 43

Deprecated: Calling static trait method Classic_SEO\Helpers\Conditional::is_heartbeat is deprecated, it should only be called on a class using the trait in /homepages.../wp-content/plugins/classicpress-seo/includes/modules/status/class-status.php on line 29

....

kiind regards

I think I am not in the position to really help ...

Current behavior

see above

Possible solution

see above

Steps to reproduce bug

see above

Context

see above

ClassicPress version

v2

PHP version

8.1

Can you help?

No, I can't help

@Soenke2 Soenke2 added status: needs triage This issue needs revision, splitting, or other gardening work type: bug Something isn't working labels Jul 4, 2023
@xxsimoxx
Copy link
Member

xxsimoxx commented Jul 4, 2023

Thank you for reporting.

This is due to Classic SEO not already being compatible with PHP > 8.0.
As far as I know there are no errors but just deprecations, that are not normally logged.

In this branch there are a lot of fixes for those errors, if you can try it it will be very helpful.

@xxsimoxx xxsimoxx removed status: needs triage This issue needs revision, splitting, or other gardening work type: bug Something isn't working labels Jul 4, 2023
@xxsimoxx
Copy link
Member

xxsimoxx commented Jul 6, 2023

Classic SEO v2.2.0-alpha.0 is out to test PHP 8.1 and 8.2 compatibility.

@xxsimoxx xxsimoxx closed this as completed Jul 6, 2023
@Soenke2
Copy link
Author

Soenke2 commented Jul 6, 2023

bravo!!!

... first five minutes testing with 8.1 ...

everything works fine (anwalt-und-kommunalrecht.de)!!!

... tomorrow I 'll update another page ... and I'll try with 8.2 ...

kind regards,
Sönke

if I should or can do something, I ask for a short message ...

@Soenke2
Copy link
Author

Soenke2 commented Jul 7, 2023

Hallo,

testing with php 8.2:

only problems with plugins:

  1. wp-matomo integration:
Deprecated: Creation of dynamic property WP_Piwik::$statsPageId is deprecated in /.../wp-content/plugins/wp-piwik/classes/WP_Piwik.php on line 387

Warning: Cannot modify header information - headers already sent by (output started at /.../wp-content/plugins/wp-piwik/classes/WP_Piwik.php:387) in /.../wp-admin/includes/misc.php on line 1444

Warning: Cannot modify header information - headers already sent by (output started at /.../wp-content/plugins/wp-piwik/classes/WP_Piwik.php:387) in /.../wp-includes/functions.php on line 6891

Warning: Cannot modify header information - headers already sent by (output started at /.../wp-content/plugins/wp-piwik/classes/WP_Piwik.php:387) in /.../wp-includes/pluggable.php on line 1427

Warning: Cannot modify header information - headers already sent by (output started at /.../wp-content/plugins/wp-piwik/classes/WP_Piwik.php:387) in /.../wp-includes/pluggable.php on line 1430

  1. yarpp (yet another related posts plugin):
Deprecated: Creation of dynamic property YARPP::$is_custom_template is deprecated in /.../wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php on line 56

Deprecated: Creation of dynamic property YARPP::$db_options is deprecated in /.../wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php on line 69

Warning: Cannot modify header information - headers already sent by (output started at /.../wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php:56) in /.../wp-admin/includes/misc.php on line 1444

Warning: Cannot modify header information - headers already sent by (output started at /.../wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php:56) in /.../wp-includes/functions.php on line 6891

Warning: Cannot modify header information - headers already sent by (output started at /.../wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php:56) in /.../wp-admin/admin-header.php on line 9

Otherwise everything is going well.

Kind regards
Sönke

@Soenke2
Copy link
Author

Soenke2 commented Jul 7, 2023

Hallo,

php 8.1:

in backend "dashboard -> updates" warning and deprecation:

Deprecated: ltrim(): Passing null to parameter #1 ($string) of type string is deprecated in /homepages/23/d278325892/htdocs/kommunalrecht/wp-includes/formatting.php on line 4414

Deprecated: ltrim(): Passing null to parameter #1 ($string) of type string is deprecated in /homepages/23/d278325892/htdocs/kommunalrecht/wp-includes/formatting.php on line 4414

Warning: Cannot modify header information - headers already sent by (output started at /homepages/23/d278325892/htdocs/kommunalrecht/wp-includes/formatting.php:4414) in /homepages/23/d278325892/htdocs/kommunalrecht/wp-admin/admin-header.php on line 9

Kind regards
Sönke

@Soenke2
Copy link
Author

Soenke2 commented Jul 7, 2023

Hallo,

updated another website (rechtsanwalt-und-verwaltungsrecht.de) to 2.0 and there are using php 8.1 the following warnings and deprecations in backend:

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /.../wp-includes/functions.php on line 7048

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /.../wp-includes/functions.php on line 2165

...

Warning: Cannot modify header information - headers already sent by (output started at /.../wp-includes/functions.php:7048) in /.../wp-admin/includes/misc.php on line 1444

Warning: Cannot modify header information - headers already sent by (output started at /.../wp-includes/functions.php:7048) in /.../wp-includes/functions.php on line 6891

Warning: Cannot modify header information - headers already sent by (output started at /.../wp-includes/functions.php:7048) in /.../wp-includes/pluggable.php on line 1427

Warning: Cannot modify header information - headers already sent by (output started at /.../wp-includes/functions.php:7048) in /.../wp-includes/pluggable.php on line 1430

Kind regards
Sönke

@KTS915
Copy link
Member

KTS915 commented Jul 7, 2023

The Deprecated: ltrim() messages seem to be a problem that ClassicPress has inherited from WordPress, and aren't connected to Classic SEO. I have already reported them at #123

@Soenke2
Copy link
Author

Soenke2 commented Jul 9, 2023

Hallo,

testing with php 8.1:

causes problems with plugin "blog2social":

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /.../wp-includes/functions.php on line 7048

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /.../wp-includes/functions.php on line 2165

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /.../wp-includes/functions.php on line 7048

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /.../wp-includes/functions.php on line 2165

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /.../wp-includes/functions.php on line 7048

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /.../wp-includes/functions.php on line 2165

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /.../wp-includes/functions.php on line 7048

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /.../wp-includes/functions.php on line 2165

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /.../wp-includes/functions.php on line 7048

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /.../wp-includes/functions.php on line 2165

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /.../wp-includes/functions.php on line 7048

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /.../wp-includes/functions.php on line 2165

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /.../wp-includes/functions.php on line 7048

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /.../wp-includes/functions.php on line 2165

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /.../wp-includes/functions.php on line 7048

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /.../wp-includes/functions.php on line 2165

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /.../wp-includes/functions.php on line 7048

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /.../wp-includes/functions.php on line 2165

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /.../wp-includes/functions.php on line 7048

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in vwp-includes/functions.php on line 2165

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /.../wp-includes/functions.php on line 7048

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /.../wp-includes/functions.php on line 2165

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /.../wp-includes/functions.php on line 7048

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /.../wp-includes/functions.php on line 2165

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /.../wp-includes/functions.php on line 7048

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /.../wp-includes/functions.php on line 2165

Warning: Cannot modify header information - headers already sent by (output started at /.../wp-includes/functions.php:7048) in /.../wp-admin/includes/misc.php on line 1444

Warning: Cannot modify header information - headers already sent by (output started at /.../wp-includes/functions.php:7048) in /.../wp-includes/functions.php on line 6891

Warning: Cannot modify header information - headers already sent by (output started at /.../wp-includes/functions.php:7048) in /.../wp-admin/admin-header.php on line 9

@Soenke2
Copy link
Author

Soenke2 commented Jul 9, 2023

php 8.2

warnings and deprecations changed little bit:

Deprecated: Creation of dynamic property YARPP::$is_custom_template is deprecated in /homepages/23/d278325892/htdocs/kommunalrecht/wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php on line 56

Deprecated: Creation of dynamic property YARPP::$db_options is deprecated in /homepages/23/d278325892/htdocs/kommunalrecht/wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php on line 69

Deprecated: Creation of dynamic property WP_Piwik::$statsPageId is deprecated in /homepages/23/d278325892/htdocs/kommunalrecht/wp-content/plugins/wp-piwik/classes/WP_Piwik.php on line 387

Warning: Cannot modify header information - headers already sent by (output started at /homepages/23/d278325892/htdocs/kommunalrecht/wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php:56) in /homepages/23/d278325892/htdocs/kommunalrecht/wp-admin/includes/misc.php on line 1444

Warning: Cannot modify header information - headers already sent by (output started at /homepages/23/d278325892/htdocs/kommunalrecht/wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php:56) in /homepages/23/d278325892/htdocs/kommunalrecht/wp-includes/functions.php on line 6891

Warning: Cannot modify header information - headers already sent by (output started at /homepages/23/d278325892/htdocs/kommunalrecht/wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php:56) in /homepages/23/d278325892/htdocs/kommunalrecht/wp-includes/pluggable.php on line 1427

Warning: Cannot modify header information - headers already sent by (output started at /homepages/23/d278325892/htdocs/kommunalrecht/wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php:56) in /homepages/23/d278325892/htdocs/kommunalrecht/wp-includes/pluggable.php on line 1430

@KTS915
Copy link
Member

KTS915 commented Jul 9, 2023

Those last ones are all caused by a specific plugin, which evidently hasn't yet been updated for PHP 8.1. (That's true of many plugins.) You need to report those issues to the plugin developer.

@Soenke2
Copy link
Author

Soenke2 commented Jul 11, 2023

Hallo,

without plugins enabled I get the following deprecation message in backend -> Media -> Media Library updating to php 8.1 (20230710):

Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in .../wp-includes/post.php on line 3017

without plugins enabled I get the following deprecation message in backend -> dashboard -> updates updating to php 8.1 (20230710):

Deprecated: ltrim(): Passing null to parameter #1 ($string) of type string is deprecated in .../wp-includes/formatting.php on line 4414

Deprecated: ltrim(): Passing null to parameter #1 ($string) of type string is deprecated in .../wp-includes/formatting.php on line 4414

Warning: Cannot modify header information - headers already sent by (output started at .../wp-includes/formatting.php:4414) in .../wp-admin/admin-header.php on line 9

(anwalt-und-kommunalrecht.de)

Kind regards
Sönke

@KTS915
Copy link
Member

KTS915 commented Jul 11, 2023

@Soenke2 You need to work out what's causing this: Warning: Cannot modify header information - headers already sent. It seems specific to your site(s) and it's going to cause other problems, which makes it difficult to know whether the other issues you've reported are actually caused by CP or, again, just specific to your site(s).

@Soenke2
Copy link
Author

Soenke2 commented Jul 12, 2023 via email

@Soenke2
Copy link
Author

Soenke2 commented Jul 12, 2023 via email

@Soenke2
Copy link
Author

Soenke2 commented Jul 12, 2023

Hallo,

12.07.2023 - v2.2023-11-07 - php 8.1:

on two websites everything works fine

php 8.2:

on one site there are reports about yarpp:

Deprecated: Creation of dynamic property YARPP::$is_custom_template is deprecated in /homepages/23/d278325892/htdocs/verwaltungsrecht/wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php on line 56

Deprecated: Creation of dynamic property YARPP::$db_options is deprecated in /homepages/23/d278325892/htdocs/verwaltungsrecht/wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php on line 69

Deprecated: Creation of dynamic property WP_Piwik::$statsPageId is deprecated in /homepages/23/d278325892/htdocs/verwaltungsrecht/wp-content/plugins/wp-piwik/classes/WP_Piwik.php on line 387

Warning: Cannot modify header information - headers already sent by (output started at /homepages/23/d278325892/htdocs/verwaltungsrecht/wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php:56) in /homepages/23/d278325892/htdocs/verwaltungsrecht/wp-admin/includes/misc.php on line 1444

Warning: Cannot modify header information - headers already sent by (output started at /homepages/23/d278325892/htdocs/verwaltungsrecht/wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php:56) in /homepages/23/d278325892/htdocs/verwaltungsrecht/wp-includes/functions.php on line 6891

Warning: Cannot modify header information - headers already sent by (output started at /homepages/23/d278325892/htdocs/verwaltungsrecht/wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php:56) in /homepages/23/d278325892/htdocs/verwaltungsrecht/wp-includes/pluggable.php on line 1427

Warning: Cannot modify header information - headers already sent by (output started at /homepages/23/d278325892/htdocs/verwaltungsrecht/wp-content/plugins/yet-another-related-posts-plugin/classes/YARPP_Core.php:56) in /homepages/23/d278325892/htdocs/verwaltungsrecht/wp-includes/pluggable.php on line 1430

It is not clear to me why no messages are displayed on the other website, on which I also use yarpp.

Sönke

p.s.: I'll update another side to v2

@xxsimoxx
Copy link
Member

This one is YARPP not fully supporting PHP 8.2.

@Soenke2
Copy link
Author

Soenke2 commented Jul 12, 2023

Hallo,

third website (rechtsanwalt-und-mietrecht.de) updated - I'll contact yarpp-support and report the bugs.

When it's done I'll report - blog2social solved problems with an update.

Well done!

Sönke

@Soenke2
Copy link
Author

Soenke2 commented Jul 12, 2023

p.s.: using php 8.1

-> dashboard -> updates there are shown two deprecations clicking updates:

Deprecated: ltrim(): Passing null to parameter #1 ($string) of type string is deprecated in /.../mietrecht/wp-includes/formatting.php on line 4414

Deprecated: ltrim(): Passing null to parameter #1 ($string) of type string is deprecated in /.../mietrecht/wp-includes/formatting.php on line 4414

When I click refresh in the browser, the messages go away.

Sönke

@jmeattle
Copy link

jmeattle commented Nov 21, 2023

This one is YARPP not fully supporting PHP 8.2.

YARPP has been updated to fully support PHP 8.2 in v5.30.7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants