Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

wp doctor check core-verify-checksums not working 🐞 #235

Open
xxsimoxx opened this issue Oct 5, 2023 · 2 comments
Open

wp doctor check core-verify-checksums not working 🐞 #235

xxsimoxx opened this issue Oct 5, 2023 · 2 comments
Labels
status: needs triage This issue needs revision, splitting, or other gardening work type: bug Something isn't working

Comments

@xxsimoxx
Copy link
Member

xxsimoxx commented Oct 5, 2023

Expected behavior

Report results.

Current behavior

It freezes.

Possible solution

No response

Steps to reproduce bug

From command line wp doctor check core-verify-checksums .

Context

No response

ClassicPress version

1.7.0
2.0.0

PHP version

7.4

Can you help?

I'll check what's happening.

@xxsimoxx xxsimoxx added status: needs triage This issue needs revision, splitting, or other gardening work type: bug Something isn't working labels Oct 5, 2023
@xxsimoxx
Copy link
Member Author

xxsimoxx commented Oct 6, 2023

Can not find a way to fix this.

wp doctor check core-verify-checksums uses a call to wp core verify-checksums.
wp core verify-checksums is obviously failing checks as WP files are different.
Both commands don't load CP (nor WP), so we can't hook at before_invoke like in this PR.

Don't know why wp doctor check core-verify-checksums hangs instead of reporting checksum mismatch,
but clearly those commands are not useful to ClassicPress users.

So my proposal is to close this issue.

@viktorix
Copy link
Member

viktorix commented Oct 7, 2023

That's probably because it uses API to get checksums:
https://github.com/wp-cli/checksum-command/blob/main/src/Checksum_Plugin_Command.php#L20

Would it be worth checking if they would accept a PR to add --classicpress option that would replace the API endpoint?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: needs triage This issue needs revision, splitting, or other gardening work type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants