Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some doubt towards the fix_mask setting in diffusion module #19

Closed
Plankson opened this issue Jul 11, 2024 · 2 comments
Closed

Some doubt towards the fix_mask setting in diffusion module #19

Plankson opened this issue Jul 11, 2024 · 2 comments

Comments

@Plankson
Copy link

Thanks for your solid work on diffusion for decision-making.
Here I have a small question about the fix_mask setting. How does the diffusion model perform if I change the fix_mask during inference? For instance, in previous baselines such as diffuser, the fix_mask is consistently set to the state at horizon=0 throughout the entire experiment. However, if I want to generate the state-action sequence given the initial state s_0 and the final state s_{#horizon-1}, can I easily modify the fix_mask during the inference stage to get desired performance? Or should I retrain the diffusion model with the new fix_mask?

@Plankson Plankson changed the title Some doubt problem towards the fix_mask setting in diffusion module Some doubt towards the fix_mask setting in diffusion module Jul 11, 2024
@ZibinDong
Copy link
Contributor

ZibinDong commented Jul 11, 2024

Thank you for using CleanDiffuser and providing feedback. : )
Since fix_mask affects model training, we cannot change the fix_mask during inference. Therefore, we do need to retrain the diffusion model with the new fix_mask.

Simply try the fix_mask below and train your new diffusion model. : )

fix_mask = torch.zeros((horizon, obs_dim + act_dim))
fix_mask[[0, -1], :obs_dim] = 1.

@Plankson
Copy link
Author

I see. Thanks for your reply! :)

@ZibinDong ZibinDong pinned this issue Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants