From f13e8182235da3356ea7093a9db2ad0b36ad8952 Mon Sep 17 00:00:00 2001 From: Apehaenger Date: Fri, 12 Apr 2024 22:11:24 +0200 Subject: [PATCH] Required HL changes for LL- Improve-Sound feature --- src/mower_comms/src/mower_comms.cpp | 7 +++---- src/open_mower/config/mower_config.sh.example | 6 +++--- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/mower_comms/src/mower_comms.cpp b/src/mower_comms/src/mower_comms.cpp index 847fd556..3b22b625 100644 --- a/src/mower_comms/src/mower_comms.cpp +++ b/src/mower_comms/src/mower_comms.cpp @@ -388,10 +388,9 @@ void handleLowLevelConfig(struct ll_high_level_config *config_pkt) { // TODO: Handle announced comms_version once required - if (config_pkt->volume >= 0) - volume = config_pkt->volume; - language = config_pkt->language; - + // We're not interested in the received langauge setting (yet) + + // We're not interested in the received volume setting (yet) if (config_pkt->type == PACKET_ID_LL_HIGH_LEVEL_CONFIG_REQ || // Config requested config_pkt->config_bitmask & LL_HIGH_LEVEL_CONFIG_BIT_DFPIS5V != dfp_is_5v) { // Our DFP_IS_5V setting is leading diff --git a/src/open_mower/config/mower_config.sh.example b/src/open_mower/config/mower_config.sh.example index 0a05b204..2510558e 100644 --- a/src/open_mower/config/mower_config.sh.example +++ b/src/open_mower/config/mower_config.sh.example @@ -61,17 +61,17 @@ export OM_MOWER_GAMEPAD="xbox360" # If you manually opened the 3.3V track and solder a bridge to 5V, then you can indicate it here to get full sound support. # DO NOT enable "OM_DFP_IS_5V=True" if you haven't changed it in real. You might risk your "Raspberry Pico"! # And even if the Pico isn't expensive, it's a torture to replace it. +# Full details are available here: https://github.com/ClemensElflein/OpenMower/blob/main/Firmware/LowLevel/README-Sound%2C%20DFPIS5V.md # export OM_DFP_IS_5V=False # # Language as ISO-639-1 code string (currently only used by sound). -# Overwrite a previously configure language (i.e. changed by CoverUI) # Supported languages: en|de # export OM_LANGUAGE="en" # # Sound volume (%) # Supported values: -# 0-100 = Set sound volume on OM start, ignoring previously set volume level (i.e. by CoverUI) -# -1 = Don't change a previusoly set volume level (i.e. by CoverUI) +# 0-100 = Set sound volume on OM start, ignoring a previously set volume level (i.e. changed by CoverUI) +# -1 = Don't change a previously set volume level (i.e. changed by CoverUI) # export OM_VOLUME=-1 ################################