Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bombastic Perks] Below the Belt do not error anymore. Seriously #79835

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Bombastic Perks] Below the Belt do not error anymore. Seriously #79835

wants to merge 1 commit into from
+2 −2

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Fix #79809

Describe the solution

Place has_alpha condition in correct place, remove it from incorrect place

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Bombastic Perks labels Feb 24, 2025
github-actions[bot]
github-actions bot reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @bombasticSlacks

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 24, 2025
@GuardianDll GuardianDll mentioned this pull request Feb 24, 2025
Closed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 24, 2025
@likowski1
Copy link

likowski1 commented Feb 24, 2025 •
edited
Loading

this Patch did Fully not fix the Issue. as the issue has evolved into a C++ Error as i had listed on #79809

here is the Error in Question
DEBUG : Tried to use an invalid alpha talker.

REPORTING FUNCTION : const_actor
C++ SOURCE FILE : D:\a\Cataclysm-DDA\Cataclysm-DDA\src\npctalk.cpp
LINE : 2656
VERSION : cdda-experimental-2025-02-24-1103

Debug.log and Crash.log is on the linked Issue

@GuardianDll
Copy link
Member Author

wrong
it errors because it tries to use alpha talker in dialogue that has no alpha talker; has_alpha condition ensure we first check if alpha talker is presented, and do not continue evaluation if it's not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Bombastic Perks Mods Issues related to mods or modding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash Caused by Bombastic Perk's "Below the Belt" Alpha Talker Check
2 participants
@GuardianDll @likowski1