Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Var.slice_intp #176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Var.slice_intp #176

wants to merge 1 commit into from

Conversation

ph-kev
Copy link
Member

@ph-kev ph-kev commented Nov 22, 2024

This PR adds slicing by using the interpolant of the OutputVar.

Helps with issue #165

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.

Project coverage is 97.82%. Comparing base (ecd089a) to head (f5d7fed).

Files with missing lines Patch % Lines
src/Var.jl 69.56% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   98.35%   97.82%   -0.54%     
==========================================
  Files          11       11              
  Lines        1218     1241      +23     
==========================================
+ Hits         1198     1214      +16     
- Misses         20       27       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this should be a keyword argument in slice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants