From b3c19736818c723ad337ac161d302d009cee5b83 Mon Sep 17 00:00:00 2001 From: Gabriele Bozzola Date: Tue, 17 Sep 2024 14:17:07 -0700 Subject: [PATCH] =?UTF-8?q?Remove=20=E1=B6=9CT=20from=20cache?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `ᶜT` was never used. It was calculated in place every time it was used. --- src/cache/cache.jl | 1 - .../gravity_wave_drag/non_orographic_gravity_wave.jl | 2 +- .../gravity_wave_drag/orographic_gravity_wave.jl | 2 +- src/parameterized_tendencies/microphysics/precipitation.jl | 3 +-- 4 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/cache/cache.jl b/src/cache/cache.jl index afe2a53d73c..3217b926761 100644 --- a/src/cache/cache.jl +++ b/src/cache/cache.jl @@ -166,7 +166,6 @@ function build_cache( ᶜΦ, ᶠgradᵥ_ᶜΦ = ᶠgradᵥ.(ᶜΦ), ᶜgradᵥ_ᶠΦ = ᶜgradᵥ.(ᶠΦ), - ᶜT = similar(Y.c, FT), ᶜf³, ᶠf¹², # Used by diagnostics such as hfres, evspblw diff --git a/src/parameterized_tendencies/gravity_wave_drag/non_orographic_gravity_wave.jl b/src/parameterized_tendencies/gravity_wave_drag/non_orographic_gravity_wave.jl index b81326b5603..14e57b11ca7 100644 --- a/src/parameterized_tendencies/gravity_wave_drag/non_orographic_gravity_wave.jl +++ b/src/parameterized_tendencies/gravity_wave_drag/non_orographic_gravity_wave.jl @@ -150,7 +150,7 @@ function non_orographic_gravity_wave_tendency!( ::NonOrographyGravityWave, ) #unpack - (; ᶜT,) = p.core + ᶜT = p.scratch.temp_scalar (; ᶜts) = p.precomputed (; params) = p (; diff --git a/src/parameterized_tendencies/gravity_wave_drag/orographic_gravity_wave.jl b/src/parameterized_tendencies/gravity_wave_drag/orographic_gravity_wave.jl index 52a6fb2dc82..197a0e6399c 100644 --- a/src/parameterized_tendencies/gravity_wave_drag/orographic_gravity_wave.jl +++ b/src/parameterized_tendencies/gravity_wave_drag/orographic_gravity_wave.jl @@ -78,7 +78,7 @@ function orographic_gravity_wave_cache(Y, ogw::OrographicGravityWave) end function orographic_gravity_wave_tendency!(Yₜ, Y, p, t, ::OrographicGravityWave) - (; ᶜT) = p.core + ᶜT = p.scratch.temp_scalar (; params) = p (; ᶜts, ᶜp) = p.precomputed (; ᶜdTdz) = p.orographic_gravity_wave diff --git a/src/parameterized_tendencies/microphysics/precipitation.jl b/src/parameterized_tendencies/microphysics/precipitation.jl index c57d7302ccc..8cb02866b4e 100644 --- a/src/parameterized_tendencies/microphysics/precipitation.jl +++ b/src/parameterized_tendencies/microphysics/precipitation.jl @@ -133,7 +133,7 @@ function compute_precipitation_surface_fluxes!( p, precip_model::Microphysics0Moment, ) - (; ᶜT) = p.core + ᶜT = p.scratch.temp_scalar (; ᶜts) = p.precomputed # assume ᶜts has been updated (; ᶜ3d_rain, ᶜ3d_snow, ᶜS_ρq_tot, ᶜS_ρe_tot) = p.precipitation (; surface_rain_flux, surface_snow_flux) = p.precipitation @@ -147,7 +147,6 @@ function compute_precipitation_surface_fluxes!( # update surface precipitation fluxes in cache for coupler's use thermo_params = CAP.thermodynamics_params(p.params) T_freeze = TD.Parameters.T_freeze(thermo_params) - @. ᶜT = TD.air_temperature(thermo_params, ᶜts) @. ᶜ3d_rain = ifelse(ᶜT >= T_freeze, ᶜS_ρq_tot, 0) @. ᶜ3d_snow = ifelse(ᶜT < T_freeze, ᶜS_ρq_tot, 0) Operators.column_integral_definite!(surface_rain_flux, ᶜ3d_rain)