Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't add atmos default diags in coupler #1029

Merged
merged 2 commits into from
Oct 18, 2024
Merged

don't add atmos default diags in coupler #1029

merged 2 commits into from
Oct 18, 2024

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Oct 17, 2024

Purpose

Currently, the nightly AMIP runs are broken because we're outputting duplicate diagnostics. This is because we're saving diagnostics via the coupler that are already output by atmos.

Also reverts JuliaFormatter to v1 after 2.0.0 release was yanked, so that formatter check will pass

To-do

  • only specify additional atmos diagnostics defined in the coupler, not diagnostics we get from atmos
  • check outputs in CI
  • revert formatter

@Sbozzolo
Copy link
Member

Maybe we should just save the coupler diagnostics in a different folder?

@juliasloan25
Copy link
Member Author

Maybe we should just save the coupler diagnostics in a different folder?

Is there a way of specifying the output folder from the config? If not, I think we would need to duplicate the atmos diagnostics in the coupler so we can use a ClimaDiagnostics writer that we define with the output path we want. Or am I missing something?

@juliasloan25
Copy link
Member Author

Maybe we should just save the coupler diagnostics in a different folder?

Is there a way of specifying the output folder from the config? If not, I think we would need to duplicate the atmos diagnostics in the coupler so we can use a ClimaDiagnostics writer that we define with the output path we want. Or am I missing something?

We discussed offline and decided to merge the fix in this PR for now, and investigate further in ClimaDiagnostics.jl why the duplicate diagnostics were not caught before

@juliasloan25 juliasloan25 merged commit f823e06 into main Oct 18, 2024
6 checks passed
@juliasloan25 juliasloan25 deleted the js/fix-diags branch October 18, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants