Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move imports out of driver, into file they're used in #1101

Closed
Tracked by #1051
juliasloan25 opened this issue Dec 2, 2024 · 1 comment
Closed
Tracked by #1051

move imports out of driver, into file they're used in #1101

juliasloan25 opened this issue Dec 2, 2024 · 1 comment
Assignees
@juliasloan25
Labels
🍃 leaf Issue coupled to a PR 💰 Grab Bag

Comments

@juliasloan25
Copy link
Member

Right now we have some package imports in our driver that are only used in an included file. This is misleading because within these files it's unclear which packages are required, and they will fail if included from a file without the correct imports. We should move these imports into the respective files.
@juliasloan25 juliasloan25 added 💰 Grab Bag 🍃 leaf Issue coupled to a PR labels Dec 2, 2024
@juliasloan25 juliasloan25 self-assigned this Dec 2, 2024
@juliasloan25 juliasloan25 mentioned this issue Dec 2, 2024
Open
@juliasloan25
Copy link
Member Author

Actually I just looked through and currently all of the packages imported in the driver are used within the driver. So no need to fix this

@juliasloan25 juliasloan25 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliasloan25 juliasloan25

Labels
🍃 leaf Issue coupled to a PR 💰 Grab Bag
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@juliasloan25