Misc refactoring #980
Merged
Misc refactoring #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/general_improvements
branch
from
41c2824
to
853f59f
Compare
juliasloan25
approved these changes
Oct 1, 2024
juliasloan25
force-pushed
the
ck/general_improvements
branch
2 times, most recently
from
be328b0
to
41bd59b
Compare
juliasloan25
force-pushed
the
ck/general_improvements
branch
from
41bd59b
to
d12a640
Compare
|
Thanks for fixing this up, @juliasloan25! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies some miscellaneous refactoring:
eltypeinAtmosSim, this should improve inference in places[FT(0)]->FT[0]guarantees the vector eltype is of typeFT, whereas the former pattern may not.ones/zeroswhen working on scalar fields.;to separate positional and keyword arguments