Use higher resolution land-sea mask #1006
Conversation
Sbozzolo
force-pushed
the
gb/landsea
branch
3 times, most recently
from
1ec7ea0 to
6ac91fd
Compare
|
We can either try using this and see if there is a problem (with our resolution I guess probably not), or use the one @akshaysridhar referenced here, which is already better than what we have now. |
Yeah this reference is in part based on the current |
This PR uses the topography artifact. Could you either check if this is ok, or add the higher resolution land sea mask to ClimaArtifact and update it in the coupler? |
Sbozzolo
force-pushed
the
gb/landsea
branch
2 times, most recently
from
e63816d to
42c98fa
Compare
Sbozzolo
force-pushed
the
gb/landsea
branch
10 times, most recently
from
c4ac880 to
7a3042b
Compare
|
I updated this PR to remove ArtifactWrappers and all the artifact infrastructure. I think this can only be merged after CliMA/ClimaAtmos.jl#3378 |
| @@ -1,8 +1,8 @@ | |||
| # This file is machine-generated - editing it directly is not advised | |||
|
|
|||
| julia_version = "1.11.1" | |||
There was a problem hiding this comment.
Maybe we want to stay at 1.11.1 unless there's a reason to go back to 1.11.0
perf/flame.jl
Outdated
| @@ -1,6 +1,8 @@ | |||
| # flame.jl: provides allocation breakdown for individual backtraces for single-process unthredded runs | |||
| # and check for overall allocation limits based on previous runs | |||
| # copied and modified from `ClimaAtmos/perf` | |||
| # | |||
| # To run this, add ProfileCanvas to the ClimaEarth environment | |||
There was a problem hiding this comment.
This should be added to flame_diff.jl and flame_test.jl too
There was a problem hiding this comment.
They don't seem to need ProfleCanvas
There was a problem hiding this comment.
Because they import ProfileCanvasDiff (which copies the code of ProfileCanvas)
As added in CliMA/ClimaArtifacts#49 60 arcseconds is already pretty high resolution
The only artifact that might be needed is ETOPO for ClimaAtmos, but that should go away soon
.buildkite/pipeline.yml
Outdated
| @@ -48,27 +41,17 @@ steps: | |||
| - echo "--- Instantiate ClimaEarth env" | |||
| - "julia --project=experiments/ClimaEarth/ -e 'using Pkg; Pkg.develop(path=\".\")'" | |||
| - "julia --project=experiments/ClimaEarth/ -e 'using Pkg; Pkg.instantiate(;verbose=true)'" | |||
| - "julia --project=experiments/ClimaEarth/ -e 'using Pkg; Pkg.add(\"MPI\"); Pkg.add(\"CUDA\")'" | |||
| - "julia --project=experiments/ClimaEarth/ -e 'using Pkg; Pkg.add(\"MPI\"); Pkg.add(\"CUDA\");" | |||
There was a problem hiding this comment.
| - "julia --project=experiments/ClimaEarth/ -e 'using Pkg; Pkg.add(\"MPI\"); Pkg.add(\"CUDA\");" | |
| - "julia --project=experiments/ClimaEarth/ -e 'using Pkg; Pkg.add(\"MPI\"); Pkg.add(\"CUDA\");'" |
As added in CliMA/ClimaArtifacts#49
30 arcseconds is already pretty high resolution
Issues closed by this PR
High-res land/sea mask closes #936
Artifact removal closes #730 and #1016
Manifest removal in seabreeze and perf closes #1056
perf/ removal closes #1057
This PR also removes all the artifact infrastructure from ClimaCoupler.