Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add amip with diagnostic edmf job #575

Merged
merged 1 commit into from
Feb 5, 2024
Merged

add amip with diagnostic edmf job #575

merged 1 commit into from
Feb 5, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Jan 25, 2024

Purpose

Adds an AMIP with edmf job to the longrun. Instead of only adding diagnostic edmf to the current amip_target_topo job, I chose to add the most realistic configuration (time-varying insolation and all-sky radiation). Because with edmf it is more than a factor of 2 slower I set t_end to 40days. This one should run, I can check once buildkite works again.

Also changes dt and dt_cpl in amip_targe_topo to be the same.

Closes #574

To-do

Content


  • I have read and checked the items on the review checklist.

@szy21 szy21 requested a review from LenkaNovak January 25, 2024 07:21
@szy21
Copy link
Member Author

szy21 commented Jan 25, 2024

I will revert the pipeline change after testing.

@szy21
Copy link
Member Author

szy21 commented Jan 25, 2024

Ah, we need a new ClimaAtmos release for this to work, as it is using a new atmos longrun config file. I can rebase the PR after we release ClimaAtmos and update ClimaCoupler this week.

@LenkaNovak
Copy link
Collaborator

@szy21, I know you're waiting for the update for CA, but FYI the macOS problem should be sorted once you rebase. Also, would it be possible to set up this run (but with a prescribed surface) in the Atmos Buildkite CPU longruns, so we can keep track of performance differences?

slurm_ntasks_per_node: 16
slurm_nodes: 4
slurm_mem_per_cpu: 16G
# - group: "Coupler integration and conservation tests"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be uncommented otherwise good to go.

@szy21
Copy link
Member Author

szy21 commented Feb 2, 2024

@szy21, I know you're waiting for the update for CA, but FYI the macOS problem should be sorted once you rebase. Also, would it be possible to set up this run (but with a prescribed surface) in the Atmos Buildkite CPU longruns, so we can keep track of performance differences?

I would prefer to keep the most important jobs in the GPU longrun, as that is what we are focusing on right now. The corresponding one in atmos is different nevertheless, as I am using idealized insolation to be more consistent with the time-invariant boundary condition. I can add a job in the CPU longrun with the exactly same setup as the coupler one for a few weeks or months for comparison.

@LenkaNovak
Copy link
Collaborator

@szy21, I know you're waiting for the update for CA, but FYI the macOS problem should be sorted once you rebase. Also, would it be possible to set up this run (but with a prescribed surface) in the Atmos Buildkite CPU longruns, so we can keep track of performance differences?

I would prefer to keep the most important jobs in the GPU longrun, as that is what we are focusing on right now. The corresponding one in atmos is different nevertheless, as I am using idealized insolation to be more consistent with the time-invariant boundary condition. I can add a job in the CPU longrun with the exactly same setup as the coupler one for a few weeks or months for comparison.

That makes sense. And yeah, that would be awesome, thank you! Or I can also do it, if you have a lot on this week. :)

@szy21
Copy link
Member Author

szy21 commented Feb 2, 2024

@LenkaNovak CliMA/ClimaAtmos.jl#2624 added the job if you want to take a look

@LenkaNovak LenkaNovak merged commit 1241c8d into main Feb 5, 2024
9 checks passed
@szy21 szy21 deleted the zs/add_diagedmf branch July 1, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stable prescribed CO2, topo, sea ice and SST + diagnostic EDMF simulation
2 participants