Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetical config arguments #599

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Alphabetical config arguments #599

merged 1 commit into from
Feb 5, 2024

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented Feb 5, 2024

closes #595


  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak marked this pull request as ready for review February 5, 2024 18:04
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion about using Linux's sort command to sort everything, which would move dt and FLOAT_TYPE for the files that have it. I think this would make it easier to standardize across repos, but if you'd rather keep this as-is that's also fine with me

.buildkite/pipeline.yml Show resolved Hide resolved
config/longrun_configs/amip_n1_shortrun.yml Outdated Show resolved Hide resolved
alphabetically sorted configs

modify gpu run name

sort after rebase

use Linux sort
@LenkaNovak LenkaNovak merged commit 4a25fc1 into main Feb 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort config alphabetically
2 participants