add atmos to table #817
Merged
add atmos to table #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/table-atmos
branch
4 times, most recently
from
412a3da to
e3db73a
Compare
juliasloan25
force-pushed
the
js/table-atmos
branch
3 times, most recently
from
28642f2 to
ad61a8c
Compare
Sbozzolo
reviewed
Jun 7, 2024
| dz_top: 3000.0 | ||
| h_elem: 30 | ||
| moist: equil | ||
| output_default_diagnostics: false |
There was a problem hiding this comment.
Maybe in a next PR we can switch the diagnostics on for our target jobs? We need to include them if the table has to be representative of realistic runs.
There was a problem hiding this comment.
Our goal for the table was not to include diagnostics, since that isn’t included in the performance goals we have. If we’re interested in understanding how long “real runs” will take, I can also add a run with diagnostics
There was a problem hiding this comment.
The performance goals should include IO: at the end, we want to look at the output.
Sbozzolo
reviewed
Jun 7, 2024
Sbozzolo
reviewed
Jun 7, 2024
test/component_model_tests/climaatmos_standalone/atmos_driver.jl
Outdated
Show resolved
Hide resolved
Sbozzolo
approved these changes
Jun 7, 2024
juliasloan25
force-pushed
the
js/table-atmos
branch
from
ad61a8c to
a5c88d9
Compare
juliasloan25
force-pushed
the
js/table-atmos
branch
from
a5c88d9 to
b011d91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
closes #778
benchmark pipeline build: https://buildkite.com/clima/climacoupler-cpu-gpu-benchmarks/builds/164
Content