Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update manifests #854

Closed
wants to merge 3 commits into from
Closed

update manifests #854

wants to merge 3 commits into from

Conversation

AlexisRenchon
Copy link
Member

@AlexisRenchon AlexisRenchon commented Jun 13, 2024

Purpose

  • ClimaLand 0.12.2 -> 0.12.3
  • ClimaAtmos 0.24.0 -> 0.25.0

Closes #758

Project.toml Outdated Show resolved Hide resolved
@Sbozzolo
Copy link
Member

So, it looks like you are also updating ClimaComms to 0.6.

I wrote some instructions on how to do that here: https://github.com/CliMA/ClimaComms.jl/wiki/Transition-to-ClimaComms.jl-0.6

@AlexisRenchon
Copy link
Member Author

@Sbozzolo @juliasloan25
It is my understanding that ClimaAtmos requires ClimaComms 0.6 now, so we can't have ClimaCoupler with ClimaComms 0.5 deps anymore. Is this correct?

@Sbozzolo
Copy link
Member

@Sbozzolo @juliasloan25 It is my understanding that ClimaAtmos requires ClimaComms 0.6 now, so we can't have ClimaCoupler with ClimaComms 0.5 deps anymore. Is this correct?

You are right. I forgot we needed to use some functions we defined in ClimaComms. So yes, we have to bump to 0.6

@AlexisRenchon
Copy link
Member Author

Should be all set - I might do another release for ClimaLand, ClimaAtmos, and update ClimaCoupler this afternoon too

Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to add the ClimaComms blurb in the tests too, if the tests use MPI or GPUs

@juliasloan25
Copy link
Member

Should be all set - I might do another release for ClimaLand, ClimaAtmos, and update ClimaCoupler this afternoon too

If the additional releases are just for the new microphysics scheme, you can make a release of ClimaAtmos without making one of ClimaLand (unless there are new features we want from land too). I find it convenient to make releases of both at the same time, but it's not strictly necessary (as long as the compats are still compatible between the two).

Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me after Gabriele's comments are addressed! Thank you, Alexis

experiments/ClimaEarth/Project.toml Outdated Show resolved Hide resolved
@AlexisRenchon
Copy link
Member Author

@Sbozzolo I am getting a lot of errors in buildkite now...
Should I update the instantiate project to .buildkite, like it has been done in other ClimaComms 0.6 PRs?

Does this, for example, require CUDA? (I thought yes because slurm_ntasks: 2

      - label: "MPI Regridder unit tests"
        key: "regridder_mpi_tests"
        command: "srun julia --color=yes --project=test/ test/mpi_tests/regridder_mpi_tests.jl --config_file $CONFIG_PATH/regridder_mpi.yml"
        timeout_in_minutes: 20
        env:
          CLIMACOMMS_CONTEXT: "MPI"
          CLIMACOMMS_DEVICE: "CUDA"
          NPROCS: 2
        agents:
          slurm_ntasks: 2
          slurm_mem: 16GB

@Sbozzolo
Copy link
Member

Some jobs are still failing, but it looks like CI was not properly trigged. Can you try again?

@akshaysridhar
Copy link
Member

akshaysridhar commented Jun 18, 2024

#864 builds on this PR to ensure that the hierarchies cases work with the recent changes to ClimaAtmos. I think we can close this and use #864 following a second review of that PR.

@akshaysridhar
Copy link
Member

#864 has been merged, so I'm closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants