-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update manifests #854
update manifests #854
Conversation
cb19cf9
to
1ea81f3
Compare
So, it looks like you are also updating ClimaComms to 0.6. I wrote some instructions on how to do that here: https://github.com/CliMA/ClimaComms.jl/wiki/Transition-to-ClimaComms.jl-0.6 |
@Sbozzolo @juliasloan25 |
You are right. I forgot we needed to use some functions we defined in ClimaComms. So yes, we have to bump to 0.6 |
9a240a7
to
861dba1
Compare
Should be all set - I might do another release for ClimaLand, ClimaAtmos, and update ClimaCoupler this afternoon too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might need to add the ClimaComms blurb in the tests too, if the tests use MPI or GPUs
If the additional releases are just for the new microphysics scheme, you can make a release of ClimaAtmos without making one of ClimaLand (unless there are new features we want from land too). I find it convenient to make releases of both at the same time, but it's not strictly necessary (as long as the compats are still compatible between the two). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me after Gabriele's comments are addressed! Thank you, Alexis
8e27130
to
4adfeb4
Compare
@Sbozzolo I am getting a lot of errors in buildkite now... Does this, for example, require CUDA? (I thought yes because
|
Some jobs are still failing, but it looks like CI was not properly trigged. Can you try again? |
#864 has been merged, so I'm closing this PR. |
Purpose
Closes #758