Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to Insolation v0.8 #381

Closed
juliasloan25 opened this issue Nov 9, 2023 · 0 comments · Fixed by #407
Closed

update to Insolation v0.8 #381

juliasloan25 opened this issue Nov 9, 2023 · 0 comments · Fixed by #407
Labels
enhancement New feature or request

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Nov 9, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
As of #380 we introduced a compat Insolation = "0.7", but v0.8 is available. I haven't updated this yet since breaking changes introduced in this release will remove ClimaLSM compatibility with previous versions of Insolation, and ClimaAtmos and ClimaCoupler are both still using v0.6. We need to coordinate when we update each of these packages to Insolation v0.8 to ensure that the coupler can still run. This should be in the next release of ClimaAtmos (after 0.16.3).

In this release, the interface for instantaneous_zenith_angle has changed, so we need to update our usage when we update.

ClimaAtmos update for Insolation v0.8: CliMA/ClimaAtmos.jl#2358
@juliasloan25 juliasloan25 added the enhancement New feature or request label Nov 9, 2023
@juliasloan25 juliasloan25 mentioned this issue Nov 9, 2023
Merged
1 task
This was referenced Nov 22, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use Insolation v0.8 CliMA/ClimaLand.jl
1 participant
@juliasloan25