Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark pipeline improvements #933

Open
3 tasks
juliasloan25 opened this issue Nov 28, 2024 · 1 comment
Open
3 tasks

Benchmark pipeline improvements #933

juliasloan25 opened this issue Nov 28, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Nov 28, 2024

Is your feature request related to a problem? Please describe.
The benchmark pipeline is helpful, but flaky. Namely, runs frequently hang and then time out, and the timing numbers we get vary a lot from run to run. We have some ideas below for ways to reduce the number of (non-meaningful) failures in this pipeline.

To do

  • decrease pipeline slurm time for the runs to 15 mins (bucket, richardsmodel) or 20 mins (soil/canopy, snowy land) to reduce wait time if runs hang
  • make hanging runs soft fail (exit code -1)
  • increase the accepted bounds for the timing value from +/- 2 to +/- 5 standard deviations
@juliasloan25 juliasloan25 added enhancement New feature or request good first issue Good for newcomers labels Nov 28, 2024
@charleskawczynski
Copy link
Member

charleskawczynski commented Jan 31, 2025

Where are the benchmark files located?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants