Include prognostic and closure options for surface area BC #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
costachris
commented
Oct 11, 2023
•
costachris
commented
- Adds options for prognostic and closure-based determination of bottom boundary condition on area. For prognostic option, surface area is prognostically determined in the bottom cell center, instead of prescribed as surface_area parameter. For closure option, bottom area determined as a linear function of surface heat fluxes.
- Initial conditions for prognostic surface area: area fraction and updraft w set to nonzero values in bottom cell center and top face, along with the associated prognostic variables. This initialization is to break symmetry and prevent trivial a = 0, w = 0 solution.
- Swaps order of set_edmf_surface_bc and filter_updraft_vars, since updraft variables are used to compute surface theta and qt fluxes.
costachris
changed the title
costachris
force-pushed
the
add_surface_a_frac_options
branch
from
7e80354
to
df56a37
Compare
costachris
force-pushed
the
add_surface_a_frac_options
branch
from
df56a37
to
794d9a0
Compare
szy21
approved these changes
Oct 11, 2023
costachris
force-pushed
the
add_surface_a_frac_options
branch
from
794d9a0
to
4b77d5c
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.