Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

png.h not actually used? #6

Open
xylar opened this issue May 12, 2024 · 1 comment · May be fixed by #7
Open

png.h not actually used? #6

xylar opened this issue May 12, 2024 · 1 comment · May be fixed by #7

Comments

@xylar
Copy link

xylar commented May 12, 2024

I spent quite a bit of time trying to understand why libpng was not actually being linked into SQuadGen. I finally concluded that all the PNG functionality is provided by lodepng and the include here is not actually needed:
https://github.com/ClimateGlobalChange/squadgen/blob/master/src/SQuadGen.cpp#L17

@paullric, can you confirm if that's the case? Is there an easy way to use an existing PNG library or is it best to just rely on lodepng?

@paullric
Copy link
Contributor

paullric commented May 13, 2024 via email

@xylar xylar linked a pull request May 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants