cork library doesn't build with clang-5

[yurivict]

CloudCompare/cork fails with errors like these:

In file included from src/cork.cpp:28:
In file included from src/mesh/mesh.h:48:
In file included from src/mesh/mesh.remesh.tpp:35:
src/mesh/mesh.topoCache.tpp:436:13: error: no matching conversion for functional-style cast from 'const char [14]' to 'std::exception'
            ENSURE(vaddr.count(v) > 0);
            ^~~~~~~~~~~~~~~~~~~~~~~~~~

In file included from src/cork.cpp:28:
In file included from src/mesh/mesh.h:48:
In file included from src/mesh/mesh.remesh.tpp:35:
src/mesh/mesh.topoCache.tpp:437:13: error: no matching conversion for functional-style cast from 'const char [14]' to 'std::exception'
            ENSURE(count(v->tris, t) == 1);
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/util/prelude.h:63:9: note: expanded from macro 'ENSURE'
                throw std::exception("ENSURE FAILED"); \
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[dgirardeau]

Shouldn't this issue be posted on the Cork repo page directly? (https://github.com/gilbo/cork) Or at least in our dedicated fork?

Anyway this library is not maintained. Therefore I fear that apart if you feel motivated to fix this issue, it will stay as is. It doesn't seem to be very challenging, but as I am not a clang user I won't be able to help.

[yurivict]

Your fork doesn't have the 'Issues' page.
Your plugin seems to depend on cork, and cork can't be built, therefore your plugin can't be built.

[dgirardeau]

Most of CC's plugins are "3rd-party" by definition. Push too far in this direction and I'll simply remove the plugin from this repo (anyway it's the fate of this plugin as, again, Cork is not maintained).

[dgirardeau]

Moreover your 'nice' demonstration eludes the fact that Cork's github repo has an Issue page (which was my first suggestion).

[asmaloney]

I see it's now been reported in the proper place: gilbo/cork#39