Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storybook 7 Migration #64

Open
2 tasks done
hemudi opened this issue May 8, 2023 · 0 comments · May be fixed by #71
Open
2 tasks done

storybook 7 Migration #64

hemudi opened this issue May 8, 2023 · 0 comments · May be fixed by #71
Assignees
@hemudi
Labels
⚙️ env

Comments

@hemudi
Copy link
Contributor

hemudi commented May 8, 2023 •
edited
Loading

예상 동작

배포를 위해 Storybook build test(#55) 를 하다 현재 Storybook 7으로 업데이트 되면서 AvatarGroup 컴포넌트에서 Custom Story Component 를 위해 적용한 defaultValue 가 작동하지 않는 현상을 발견했습니다.

스크린샷 2023-05-08 오전 10 13 06

원인을 찾던 중 defaultValue not working in Storybook 7 해당 이슈를 보고 Storybook 7로 업그레이드한게 원인 임을 알게 되었고 해당 이슈를 해결 함과 동시에 전체적으로 Story 코드들을 Storybook 7에 맞게 마이그레이션 해야 할 필요성을 느꼈습니다.

Migration Task List

  • (deprecated) ComponentStory, ComponentMeta -> StoryObj, Meta
  • MIGRATION 문서를 읽고 더 추가될 예정
@hemudi hemudi changed the title Migration storybook 7 storybook 7 Migration May 8, 2023
@hemudi hemudi self-assigned this May 8, 2023
@hemudi hemudi linked a pull request May 30, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hemudi hemudi

Labels
⚙️ env
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Hemdi] Storybook 7 Migration Co-Studo/cos-ui
1 participant
@hemudi