Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

outline: revert causes a segfault #30

Open
r1bilski opened this issue Nov 19, 2023 · 0 comments
Open

outline: revert causes a segfault #30

r1bilski opened this issue Nov 19, 2023 · 0 comments

Comments

@r1bilski
Copy link

r1bilski commented Nov 19, 2023 •
edited
Loading

Repro:

  1. Open the following html
<!DOCTYPE html>
<html lang="en">
  <body>
    <h1>Test</h1>
  </body>
</html>
<style>
h1 {
  outline: revert;
}
</style>
  1. The application will crash

It seems that select_state->origin is NULL but we try to index it in contrib/libcss/src/select/select.c:1107.

Edit:
I spent some time looking for the reason behind this, and I assume it's because uses_revert is not set for the stylesheet, meaning it's not set for the ctx neither, leading to state.revert not getting initialized at contrib/libcss/src/select/select.c:1239.
It seems to me that this flag should get set in the autogenerated property code, but isn't.
@r1bilski r1bilski changed the title Opening any stack overflow question results in a segfault outline: revert causes a segfault Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@r1bilski