Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask for confirmation before applying dangerous commands #19

Closed
lucasbrunialti opened this issue Sep 28, 2017 · 4 comments
Closed

Ask for confirmation before applying dangerous commands #19

lucasbrunialti opened this issue Sep 28, 2017 · 4 comments
Labels
Hacktoberfest

Comments

@lucasbrunialti
Copy link
Member

No description provided.

@argumentofperiapsis
Copy link

Which commands are deemed dangerous? Just askin' 😉

@lucasbrunialti
Copy link
Member Author

lucasbrunialti commented Sep 28, 2017 •
edited
Loading

  • reset is a really dangerous command, because it drops the keyspace
  • migrate is a dangerous command because if you apply something that was not supposed to be applied, you can't rollback (see Rollback support #2)

Also, it would be nice to have an option to not ask anything...

@danielkza
Copy link
Contributor

My idae is to show a prompt if we're running interactively (if stdin is a TTY), and to provide a --yes option that always skips checks.

@julienc91 julienc91 mentioned this issue Oct 1, 2017
Merged
@danielkza
Copy link
Contributor

Fixed by #21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielkza @lucasbrunialti @argumentofperiapsis