Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicValidator implementation is incomplete in mold #397

Closed
HoOngEe opened this issue May 19, 2020 · 1 comment
Closed

DynamicValidator implementation is incomplete in mold #397

HoOngEe opened this issue May 19, 2020 · 1 comment
Labels
mold Module system

Comments

@HoOngEe
Copy link
Contributor

HoOngEe commented May 19, 2020

next_block_proposer method of the trait ValidatorSet have assumed that validators method returns the validators sorted in a desirable order so that it can just pick the next validator by the index view.
However, the ordering rule changed after #388 and the previous behavior can not be simulated by the SimpleValidator in mold which only contains voting_power and public_key. I can copy the previous logic properly to recover the behavior.
@HoOngEe HoOngEe added the mold Module system label May 19, 2020
@HoOngEe HoOngEe self-assigned this May 19, 2020
@majecty
Copy link
Contributor

majecty commented Dec 22, 2020

The behavior is changed here: #602
We will track the problem here: #603

@majecty majecty closed this as completed Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mold Module system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@majecty @HoOngEe