Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a refresh of cached icons #8

Open
Andre601 opened this issue Jun 21, 2022 · 3 comments
Open

Allow a refresh of cached icons #8

Andre601 opened this issue Jun 21, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Andre601
Copy link
Contributor

Right now exists a minor, yet annoying issue in ATO (And most likely also BTLP).

The issue is, that icons that have been cached may not get updated whenever the corresponding PNG file has been altered.
As an example, when I create a file called example.png and use it inside a tab will ATO/BTLP generate a new icon to use in the tab list, which makes sense.
When I now alter the icon (f.e. change the background color) while keeping the name and configuration the same and then do a plugin reload is ATO/BTLP ignoring the changed file, forcing me to first stop the server/proxy, delete the cache file and start the server/proxy again.

A solution I had in mind would be to make ATO/BTLP force-refresh the cache whenever you reload the plugin while the cache file isn't present. Because as of right now are the plugins ignoring whether the file is present or not during a reload, which is annoying.
That way could icons get updated while you don't have to deal with stuff such as comparing the old/cached image with the new one to see if there are differences.


Another issue I noticed is, that icons may not load after they have been generated. Like while ATO/BTLP is generating the new icon using Mineskin is a loading animation displayed.
Usually, this icon would then be replaced with the generated one once it is available. But it can randomly happen that ATO/BTLP doesn't update the icon and the slot(s) stick with that loading animation.
A reload of the plugin does fix this, but it's still weird that this happens and should perhaps be looked into.

@CodeCrafter47
Copy link
Owner

As far as I can tell the reload/ icon cache problem only exists in ATO. I pushed some changes to the dev branch to address that.
Regarding icons loading forever, I have improved the error handling when using the mineskin api, You should now see the black/ purple error icon and an error message in the proxy log. I will probably add some retry mechanism in the future.

@CodeCrafter47 CodeCrafter47 added the bug Something isn't working label Jun 29, 2022
@Andre601
Copy link
Contributor Author

Will try testing a bit

@Andre601
Copy link
Contributor Author

Andre601 commented Jun 29, 2022

Seems like latest build failed due to some unresolved dependencies.
Maybe the repo is/was down?

Screenshot straight from the Jenkins
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants