You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Talk directly to docker daemon using dockerHost to perform operation.
I'm wondering if we can just talk to Swarm all the time and also skip dockExist check. In the current scenario we make 2 calls: 1 to swarm and 1 to docker daemon. In the new scenario we will have 1 call to swarm.
Benefits:
Less calls (1 < 2)
Jobs become more lightweight since they will not have job.dockerHost property
Jobs can be reused by other systems. E.x. API would be able to enqueue a job for container removal/deletion without specifying dockerHost.
I'm looking into
container.remove
andcontainer.delete
tasks (https://github.com/CodeNow/khronos/blob/master/lib/tasks/containers/remove.js#L37).They bot have following logic:
dockerHost
to perform operation.I'm wondering if we can just talk to Swarm all the time and also skip dockExist check. In the current scenario we make 2 calls: 1 to swarm and 1 to docker daemon. In the new scenario we will have 1 call to swarm.
Benefits:
job.dockerHost
propertyContext:
I'm thinking about removing this piece of code from API (https://github.com/CodeNow/api/blob/master/lib/workers/instance.container.delete.js#L68).
Theoretically API can either enqueue
khronos.container.remove
job or emit a new even that khronos can pick it up (I think I like second option better but open for your comments)The text was updated successfully, but these errors were encountered: