Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_delete_profile #54

Open
Nalipp opened this issue Aug 8, 2017 · 6 comments
Open

fix_delete_profile #54

Nalipp opened this issue Aug 8, 2017 · 6 comments
Labels

Comments

@Nalipp
Copy link
Collaborator

Nalipp commented Aug 8, 2017

Right now the delete profile just redirects to the user profile page without deleting
also need some sort of waring before deleting a user profile

@Nalipp Nalipp added the bug label Aug 8, 2017
@Nalipp Nalipp assigned Nalipp and unassigned Nalipp Aug 8, 2017
@AhmedShab
Copy link

Hey@Nalipp, I'm keen to look into this issue 😄

@AhmedShab
Copy link

Hmm, I was trying to add a user (on my local machine) but it seems like I need to add a course beforehand 🤔? You guys don't seed the database? It's pretty nice technique to fill in the database.

@AhmedShab
Copy link

Don't worry, I tried to add a user manually to the database. It seems alright for now. Will work on this shorty.

@AhmedShab
Copy link

AhmedShab commented Nov 17, 2017

I fixed the problem. The reason why it was doing that because we had a nested form. If you do that, it will take the first action from the parent form and it won't work. I moved the form but now the I have to fix the layout

image

@AhmedShab
Copy link

AhmedShab commented Nov 17, 2017

Sorry if I've been posting a lot haha. The delete button seems a bit odd to me having it on the edit page. It's not just because I can't place it next to the submit button but also when you edit your detail, I won't expect to delete it as well.

I would suggest adding delete next to edit button. If you like that, I can make that change. Please let me know what you think 😃

Here is what I meant:
image

@TheBeege
Copy link
Member

This is a good idea. Let's do it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants