Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix using multiple positions at the same time #635

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix using multiple positions at the same time #635

wants to merge 1 commit into from

Conversation

antriver
Copy link

Fixes #438

@phoward38 phoward38 mentioned this pull request Aug 6, 2020
Merged
@zverev78
Copy link

It will create multiple <div>s with the same id. Not an ideal solution.
Possibly we should change containerId to options.containerId + '-' + options.positionClass when options.containerId is default (i.e. == getDefaults().containerId),
change in css all #toast-container to .toast-container
and add this css class in createContainer().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple toasts with different positions take first position
2 participants
@antriver @zverev78