From b65254af31395b7233154fdbcde54d992ce37692 Mon Sep 17 00:00:00 2001 From: rawrnoodles Date: Mon, 13 Jan 2025 18:58:49 +0000 Subject: [PATCH 1/4] script.js - fixed listed bugs --- debugging/book-library/script.js | 90 +++++++++++++------------------- 1 file changed, 35 insertions(+), 55 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1..27ab5b9 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,22 +1,15 @@ let myLibrary = []; -window.addEventListener("load", function (e) { +window.addEventListener("load", function () { populateStorage(); render(); }); function populateStorage() { - if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( - "The Old Man and the Sea", - "Ernest Hemingway", - "127", - true - ); - myLibrary.push(book1); - myLibrary.push(book2); - render(); + if (myLibrary.length === 0) { + let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true); + let book2 = new Book("The Old Man and the Sea", "Ernest Hemingway", "127", true); + myLibrary.push(book1, book2); } } @@ -25,22 +18,19 @@ const author = document.getElementById("author"); const pages = document.getElementById("pages"); const check = document.getElementById("check"); -//check the right input from forms and if its ok -> add the new book (object in array) -//via Book function and start render function function submit() { - if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" - ) { + if (!title.value || !author.value || !pages.value) { alert("Please fill all fields!"); return false; - } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); - render(); } + if (isNaN(pages.value) || pages.value <= 0) { + alert("Please enter a valid number of pages!"); + return false; + } + + let book = new Book(title.value, author.value, pages.value, check.checked); + myLibrary.push(book); + render(); } function Book(title, author, pages, check) { @@ -53,51 +43,41 @@ function Book(title, author, pages, check) { function render() { let table = document.getElementById("display"); let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { + + // Delete old rows + for (let n = rowsNumber - 1; n > 0; n--) { table.deleteRow(n); } - //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; - //add and wait for action for read/unread button + // Insert updated rows + for (let i = 0; i < myLibrary.length; i++) { + let row = table.insertRow(-1); + + row.insertCell(0).innerText = myLibrary[i].title; + row.insertCell(1).innerText = myLibrary[i].author; + row.insertCell(2).innerText = myLibrary[i].pages; + + let wasReadCell = row.insertCell(3); let changeBut = document.createElement("button"); changeBut.id = i; changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; - + changeBut.innerText = myLibrary[i].check ? "Yes" : "No"; changeBut.addEventListener("click", function () { myLibrary[i].check = !myLibrary[i].check; render(); }); + wasReadCell.appendChild(changeBut); - //add delete button to every row and render again + let deleteCell = row.insertCell(4); let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { + delButton.id = i + 5; + delButton.className = "btn btn-warning"; + delButton.innerHTML = "Delete"; + delButton.addEventListener("click", function () { alert(`You've deleted title: ${myLibrary[i].title}`); myLibrary.splice(i, 1); render(); }); + deleteCell.appendChild(delButton); } -} +} \ No newline at end of file From 0b6204bbe49d6c6438f7aa655f4272086b747912 Mon Sep 17 00:00:00 2001 From: rawrnoodles Date: Fri, 17 Jan 2025 20:51:08 +0000 Subject: [PATCH 2/4] script.js - moved alert for delete button after the book is deleted. --- debugging/book-library/script.js | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 27ab5b9..7dbea4c 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -73,11 +73,14 @@ function render() { delButton.id = i + 5; delButton.className = "btn btn-warning"; delButton.innerHTML = "Delete"; - delButton.addEventListener("click", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); - myLibrary.splice(i, 1); - render(); - }); + delButton.addEventListener("click", (function(index) { + return function() { + const removedTitle = myLibrary[index].title; + myLibrary.splice(index, 1); + render(); + alert(`You've deleted title: ${removedTitle}`); + }; + })(i)); deleteCell.appendChild(delButton); } } \ No newline at end of file From 288340751255dd766b734d24af6dca04a8a6d583 Mon Sep 17 00:00:00 2001 From: rawrnoodles Date: Fri, 17 Jan 2025 21:22:29 +0000 Subject: [PATCH 3/4] script.js - removed ids' and used dataset.index instead --- debugging/book-library/script.js | 38 ++++++++++++++++---------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 7dbea4c..f7df693 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -58,29 +58,29 @@ function render() { row.insertCell(2).innerText = myLibrary[i].pages; let wasReadCell = row.insertCell(3); - let changeBut = document.createElement("button"); - changeBut.id = i; - changeBut.className = "btn btn-success"; - changeBut.innerText = myLibrary[i].check ? "Yes" : "No"; - changeBut.addEventListener("click", function () { + let toggleButton = document.createElement("button"); + toggleButton.dataset.index = i; + toggleButton.className = "btn btn-success"; + toggleButton.innerText = myLibrary[i].check ? "Yes" : "No"; + toggleButton.addEventListener("click", function () { + const index = this.dataset.index; myLibrary[i].check = !myLibrary[i].check; render(); }); - wasReadCell.appendChild(changeBut); + wasReadCell.appendChild(toggleButton); let deleteCell = row.insertCell(4); - let delButton = document.createElement("button"); - delButton.id = i + 5; - delButton.className = "btn btn-warning"; - delButton.innerHTML = "Delete"; - delButton.addEventListener("click", (function(index) { - return function() { - const removedTitle = myLibrary[index].title; - myLibrary.splice(index, 1); - render(); - alert(`You've deleted title: ${removedTitle}`); - }; - })(i)); - deleteCell.appendChild(delButton); + let deleteButton = document.createElement("button"); + deleteButton.dataset.index = i; + deleteButton.className = "btn btn-warning"; + deleteButton.innerHTML = "Delete"; + deleteButton.addEventListener("click", function () { + const index = this.dataset.index; + const removedTitle = myLibrary[index].title; + myLibrary.splice(index, 1); + render(); + alert(`You've deleted title: ${removedTitle}`); + }); + deleteCell.appendChild(deleteButton); } } \ No newline at end of file From 95a7ff8a0c5da68f28b6a12971cf8a150b5e02e2 Mon Sep 17 00:00:00 2001 From: rawrnoodles Date: Fri, 17 Jan 2025 22:12:31 +0000 Subject: [PATCH 4/4] index.html - made fixes to index.html --- debugging/book-library/index.html | 139 +++++++++++------------------- debugging/book-library/script.js | 2 +- 2 files changed, 52 insertions(+), 89 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa7..a45540c 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,96 +1,59 @@ - - - - - - - - - - -
-

Library

-

Add books to your virtual library

-
+ + Library + + + + + + + + + +
+

Library

+

Add books to your virtual library

+
+ + + +
+
+ + - + + -
-
- - - - - - - - -
+ + + + + +
+
+ + + + + + + + + + + + +
TitleAuthorNumber of PagesRead
- - - - - - - - - - - - - - - - - - - -
TitleAuthorNumber of PagesRead
+ + - - - + \ No newline at end of file diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index f7df693..feba562 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -16,7 +16,7 @@ function populateStorage() { const title = document.getElementById("title"); const author = document.getElementById("author"); const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +const check = document.getElementById("read-checkbox"); function submit() { if (!title.value || !author.value || !pages.value) {