Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo Implementation TODO #37

Open
1 of 11 tasks
Toyz opened this issue Nov 10, 2018 · 8 comments
Open
1 of 11 tasks

Logo Implementation TODO #37

Toyz opened this issue Nov 10, 2018 · 8 comments

Comments

@Toyz
Copy link
Contributor

Toyz commented Nov 10, 2018

Below is a list of things that still need to be implemented into the parser for the logo language:

  • circle > circle radius extend steps
  • dot > dot radius
  • pensize > pensize strokeSize
  • pencolor > pencolor color
  • fillcolor > fillcolor color note: this is dealing with custom shapes which we currently don't support yet
  • fill > fill true/false note: uses fillcolor to fill the shape if true
  • begin_fill > start shape
  • end_fill > end shape
  • write > write text note: this writes to the canvas as text ex "hello world"

Things to implement in turtle to add more features:

  • Dynamic stroke size so we can change it with pensize
  • Ability to create shapes and ill them with a solid color

--

Note: In Logo color sets both fillcolor and pencolor, this means we don't actually implement color properly yet

@shiffman
Copy link
Member

Is this up to date?

@Toyz
Copy link
Contributor Author

Toyz commented Nov 13, 2018 via email

@NiclasTheSquirrel
Copy link

Circle mode center or corner`??

@TheTastefulToastie
Copy link
Collaborator

@Toyz Hi for #75 do you know where the circle command is documented?
Looking in the Berkeley Logo Manual I can only find the ARC command:

ARC angle radius

	draws an arc of a circle, with the turtle at the center, with the
	specified radius, starting at the turtle's heading and extending
	clockwise through the specified angle.  The turtle does not move.

Should we implement a circle command because it's intuitive? or just support Berkeley Logo (which has only ARK or both?

@NiclasTheSquirrel
Copy link

For color, should it be rgb, or should it be like this:
command 51 (rgb: 51,51,51)

@Toyz
Copy link
Contributor Author

Toyz commented Dec 30, 2018

Circle could he a shortcut to arc

@Toyz
Copy link
Contributor Author

Toyz commented Dec 30, 2018

And we could change the color command to support rgb instead of having a colorrgb function

@NiclasTheSquirrel
Copy link

So we should replace the color command with colorRGB or just make it support both hex and RGB?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants