Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Github Checks API #1400

Open
mandeep-singh-ck opened this issue Dec 18, 2024 · 3 comments
Open

Support Github Checks API #1400

mandeep-singh-ck opened this issue Dec 18, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@mandeep-singh-ck
Copy link

mandeep-singh-ck commented Dec 18, 2024

It gets very noisy to keep commenting on the root of a PR, instead a Github Checks run can give a canvas for the review in a dedicated spot per commit. https://docs.github.com/en/apps/creating-github-apps/writing-code-for-a-github-app/building-ci-checks-with-a-github-app

@mrT23
Copy link
Collaborator

mrT23 commented Dec 19, 2024

I don't understand what you are referring to.
Provide pictures and more details

@mandeep-singh-ck
Copy link
Author

@mrT23 Here is an example of github checks:
image (source)

It is essentially a markdown canvas for each commit in a pull request. It minimizes the amount of comments that the bot posts on the main PR conversation tab - which can easily get lost. GitHub Checks api also supports suggestions, applying changes, and more.

@mrT23
Copy link
Collaborator

mrT23 commented Jan 10, 2025

@mandeep-singh-ck
Thanks for the idea.
I did not know you could put a markdown in the checks tab. It is usually used to present (ugly) workflow logs
image
(but I guess that in the end this log page is just a markdown...)

We will look into that, if indeed it can be a viable place to put feedback in a less 'noisy' way

@mrT23 mrT23 added good PR enhancement New feature or request and removed clarification needed good PR labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants