Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/crafts always try to find auctions #1249

Open
Ekwav opened this issue Apr 21, 2024 · 6 comments
Open

/crafts always try to find auctions #1249

Ekwav opened this issue Apr 21, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@Ekwav
Copy link
Member

Ekwav commented Apr 21, 2024

It opens https://sky.coflnet.com/item/ENCHANTED_DIAMOND_BLOCK?itemFilter=eyJCaW4iOiJ0cnVlIn0%3D&range=active which doesn't display bazaar graphs.
Either the craft section should change the link or the bazaar view should not care about the active option and default to day

@matthias-luger
Copy link
Collaborator

fixed by d4166cb

@Ekwav
Copy link
Member Author

Ekwav commented Apr 22, 2024

When it is an auction it should still focus the active tab as the user may want to see what the cheapest available auction is.
So this change broke that behavior.
Should I maybe add an endpoint that contains a command for getting to the item (bazaar for bazaar items and /viewauction for ah)
Would replace the craft recipe endpoint (also return the recipe) and called when a user clicks to see the detailed view

@Ekwav Ekwav reopened this Apr 22, 2024
@matthias-luger
Copy link
Collaborator

Yes, that would be a good idea :)

@matthias-luger
Copy link
Collaborator

@Ekwav Is there already an issue for this?

@Ekwav
Copy link
Member Author

Ekwav commented Dec 21, 2024

There was not, this is it Coflnet/SkyApi#129

@Ekwav
Copy link
Member Author

Ekwav commented Dec 23, 2024

/api/craft/HYPERION/instructions

@Ekwav Ekwav added enhancement New feature or request and removed Waiting for backend labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants