Fix Dup2X1 and Dup2X2 analysis impls being swapped

Thank you soostrator for pointing that out
Col-E · Aug 10, 2023 · 1959680 · 1959680
1 parent 0f123fd
commit 1959680
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/recaf-assembler/src/main/java/me/coley/recaf/assemble/analysis/insn/Dup2X1Executor.java b/recaf-assembler/src/main/java/me/coley/recaf/assemble/analysis/insn/Dup2X1Executor.java
@@ -16,10 +16,8 @@ public void handle(Frame frame, AbstractInstruction instruction) throws Analysis
 		Value value1 = frame.pop();
 		Value value2 = frame.pop();
 		Value value3 = frame.pop();
-		Value value4 = frame.pop();
 		frame.push(value2); // inserted
 		frame.push(value1); // inserted
-		frame.push(value4); // original
 		frame.push(value3); // original
 		frame.push(value2); // original
 		frame.push(value1); // original

diff --git a/recaf-assembler/src/main/java/me/coley/recaf/assemble/analysis/insn/Dup2X2Executor.java b/recaf-assembler/src/main/java/me/coley/recaf/assemble/analysis/insn/Dup2X2Executor.java
@@ -16,8 +16,10 @@ public void handle(Frame frame, AbstractInstruction instruction) throws Analysis
 		Value value1 = frame.pop();
 		Value value2 = frame.pop();
 		Value value3 = frame.pop();
+		Value value4 = frame.pop();
 		frame.push(value2); // inserted
 		frame.push(value1); // inserted
+		frame.push(value4); // original
 		frame.push(value3); // original
 		frame.push(value2); // original
 		frame.push(value1); // original