chore: simplify numpy code of matrix expressions #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renders the numpy module as a link as well if not explicitly imported.
redeboer
added a commit
that referenced
this pull request
Feb 22, 2022
* docs: automatically widen numpycode code-blocks * docs: extend codeautolink_global_preface This renders numpy module as a link as well if not explicitly imported. * docs: render _numpycode() output as python code-block * fix: remove redundant transpose import * fix: run QRules single-threaded in tests * refactor: extract _RotationY/ZMatrixImplementation * refactor: extract _BoostZMatrixImplementation * refactor: remove angle property from RotationY/Z classes * refactor: remove beta property from BoostZMatrix * test: add tests RotationY/ZMatrix * test: check numpycode with cse in nested expression
redeboer
added a commit
that referenced
this pull request
Feb 22, 2022
* docs: automatically widen numpycode code-blocks * docs: extend codeautolink_global_preface This renders numpy module as a link as well if not explicitly imported. * docs: render _numpycode() output as python code-block * fix: remove redundant transpose import * fix: run QRules single-threaded in tests * refactor: extract _RotationY/ZMatrixImplementation * refactor: extract _BoostZMatrixImplementation * refactor: remove angle property from RotationY/Z classes * refactor: remove beta property from BoostZMatrix * test: add tests RotationY/ZMatrix * test: check numpycode with cse in nested expression
redeboer
added a commit
that referenced
this pull request
Feb 22, 2022
* docs: automatically widen numpycode code-blocks * docs: extend codeautolink_global_preface This renders numpy module as a link as well if not explicitly imported. * docs: render _numpycode() output as python code-block * fix: remove redundant transpose import * fix: run QRules single-threaded in tests * refactor: extract _RotationY/ZMatrixImplementation * refactor: extract _BoostZMatrixImplementation * refactor: remove angle property from RotationY/Z classes * refactor: remove beta property from BoostZMatrix * test: add tests RotationY/ZMatrix * test: check numpycode with cse in nested expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #231
Extracted
NumPyPrintableimplementation classes fromBoostZMatrix,RotationYMatrixandRotationZMatrix, so that the code generated withsympy.lambdify()decreases and has a smaller memory footprint (if usingcse=True). This can best be seen by comparing the new docstring forBoostZMatrixwith the old one.