Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve symbol assumptions #268

Closed
3 tasks done
redeboer opened this issue Apr 6, 2022 · 0 comments · Fixed by #271
Closed
3 tasks done

Improve symbol assumptions #268

redeboer opened this issue Apr 6, 2022 · 0 comments · Fixed by #271
Assignees
@redeboer
Labels
❗ Behavior Changes that may affect the framework output
Milestone
0.14.0

Comments

@redeboer
Copy link
Member

redeboer commented Apr 6, 2022 •
edited
Loading

Assumptions on kinematic variables and parameters are currently mostly set to real=True. This prevents SymPy from a proper simplification, see for instance this amplitude, which (may) have influence function tree performance in TensorWaves.

Case in point are invariant masses, where expression often contain something like \sqrt{m^2}. With real=True, this reduces to |m|, whereas we probably just want m.
@redeboer redeboer added the ❗ Behavior Changes that may affect the framework output label Apr 6, 2022
@redeboer redeboer added this to the 0.14.0 milestone Apr 6, 2022
@redeboer redeboer self-assigned this Apr 6, 2022
This was referenced Apr 6, 2022
Merged
Merged
Merged
@redeboer redeboer added this to Roadmap Apr 6, 2022
@redeboer redeboer moved this to Upcoming in Roadmap Apr 6, 2022
@redeboer redeboer removed the status in Roadmap Jul 27, 2022
@redeboer redeboer moved this to Released in Roadmap Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redeboer redeboer

Labels
❗ Behavior Changes that may affect the framework output
Projects
Roadmap
Status: Released
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

refactor: make mass and width symbols non-negative redeboer/ComPWA-ampform
1 participant
@redeboer