Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HelicityModel.sum_components() method #296

Closed
redeboer opened this issue Jun 7, 2022 · 0 comments · Fixed by #304
Closed

Remove HelicityModel.sum_components() method #296

redeboer opened this issue Jun 7, 2022 · 0 comments · Fixed by #304
Assignees
Labels
⚠️ Interface Breaking changes to the API
Milestone

Comments

@redeboer
Copy link
Member

redeboer commented Jun 7, 2022

HelicityModel.sum_components() is quite sensitive to bugs, because it checks patterns in parameter names and also is not well tested for interference effects and then computes coherent vs incoherent sums based on those names. It would be better to leave it up to the user to set certain coefficients/couplings to zero in the function as lambdified with TensorWaves, so that the summing is guaranteed to be the same as in the total model.

@redeboer redeboer added the ⚠️ Interface Breaking changes to the API label Jun 7, 2022
@redeboer redeboer added this to the 0.15.0 milestone Jun 7, 2022
@redeboer redeboer self-assigned this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ Interface Breaking changes to the API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant