Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Release the latest version #2

Closed
kenji-miyake opened this issue Jan 21, 2022 · 8 comments
Closed

Release the latest version #2

kenji-miyake opened this issue Jan 21, 2022 · 8 comments
Labels
💡 Enhancement New feature or improvement of existing code

Comments

@kenji-miyake
Copy link
Contributor

Problem description

Today, v3.9.1 has been released.
This resolves the error of multiple inputs. tcort/markdown-link-check#78

Proposed solution

@redeboer Could you release the latest release, please? 🙏

@kenji-miyake kenji-miyake added the 💡 Enhancement New feature or improvement of existing code label Jan 21, 2022
@redeboer
Copy link
Member

Hi @kenji-miyake, thanks for notifying! I hadn't noticed that GitHub has deactivated the upgrade cron job due to inactivity (within 60 days). I've manually run the upgrade job and will reduce the cron job time to avoid this (🤞 ) in the future.

@kenji-miyake
Copy link
Contributor Author

Oh, thank you for your quick reply. 😄

@kenji-miyake
Copy link
Contributor Author

Released. https://github.com/ComPWA/mirrors-markdown-link-check/releases/tag/v3.9.1

@redeboer
Copy link
Member

Btw, it seems that the upstream repo has defined a .pre-commit-hooks.yaml now: tcort/markdown-link-check@6095b28. Perhaps that makes this mirror redundant?

@kenji-miyake
Copy link
Contributor Author

@redeboer I'm sorry, there was a bug. 🥺
tcort/markdown-link-check#182

Btw, it seems that the upstream repo has defined a .pre-commit-hooks.yaml now: tcort/markdown-link-check@6095b28. Perhaps that makes this mirror redundant?

Ah, it might be so, I forgot that.
I think this repository can be archived, but anyway, it was very helpful for me.
Thank you!

@redeboer
Copy link
Member

I'm sorry, there was a bug. 🥺

Ok no problem, I'll rerun the upgrade job once a new upstream release is out.

I think this repository can be archived, but anyway, it was very helpful for me.

Give it a try, switching the repo url of your hook to https://github.com/tcort/markdown-link-check. The pre-commit-hooks config looks different than the one in this mirror though, so if it works, it could be pre-commit just runs a local Node.js version of markdown-link-check if you also installed that (I'm not developing in node, so not sure).

@kenji-miyake
Copy link
Contributor Author

I tested it here and it worked!
autowarefoundation/autoware.universe#283

@redeboer
Copy link
Member

I tested it here and it worked!
autowarefoundation/autoware.universe#283

Yup, just tried it locally as well, works well. So I'll archive this repo --> b0fa1e6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💡 Enhancement New feature or improvement of existing code
Projects
None yet
Development

No branches or pull requests

2 participants