Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pre-commit black on notebooks via official hook #169

Closed
16 tasks done
Tracked by #175
redeboer opened this issue Sep 25, 2023 · 0 comments · Fixed by #171, ComPWA/qrules#230, ComPWA/gluex-amplitude#22, ComPWA/benchmarks#18 or ComPWA/ampform#358
Closed
16 tasks done
Tracked by #175
Assignees
Labels
🖱️ DX Improvements to the Developer Experience

Comments

@redeboer
Copy link
Member

redeboer commented Sep 25, 2023

Currently, notebooks are formatted with black using nbqa-black. This, however, does not guarantee that the version of black used by nbQA is the same as the black used for .py files. Nowadays black provides its own pre-commit hook for notebooks though, which would guarantee the same version is run on both .py and .ipynb files.

Example: ComPWA/compwa.github.io@ac0c5d2, where pre-commit.ci is still using a (cached) lower version for black than the one that was used locally for the PR.

Implementation

Preview Give feedback
  1. 🖱️ DX
    redeboer
  2. 🔨 Maintenance
    redeboer
  3. 🔨 Maintenance
    redeboer
  4. 🔨 Maintenance
    redeboer
  5. 🔨 Maintenance
    redeboer
  6. 🔨 Maintenance
    redeboer
  7. 🔨 Maintenance
    redeboer
  8. 🔨 Maintenance
    redeboer
  9. 🔨 Maintenance
    redeboer
  10. 🔨 Maintenance
    redeboer
  11. 🔨 Maintenance
    redeboer
  12. 🔨 Maintenance
    redeboer
  13. 🔨 Maintenance
    redeboer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment