Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use frozendict package instead of custom FrozenDict class #309

Closed
redeboer opened this issue Dec 19, 2024 · 0 comments · Fixed by #310
Closed

Use frozendict package instead of custom FrozenDict class #309

redeboer opened this issue Dec 19, 2024 · 0 comments · Fixed by #310
Assignees
Labels
⚙️ Enhancement Improvements and optimizations of existing features
Milestone

Comments

@redeboer
Copy link
Member

In ComPWA/ampform#444 (comment) it became clear that the pickled form of FrozenDict (and therefore of Topology, ReactionInfo etc.) does not have a stable hash (as computed with xxhash). The frozendict package does provide a stable hash, so it should be tested whether FrozenDict can be replaced by it.

@redeboer redeboer added the ⚙️ Enhancement Improvements and optimizations of existing features label Dec 19, 2024
@redeboer redeboer self-assigned this Dec 19, 2024
@redeboer redeboer added this to the 0.11.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Enhancement Improvements and optimizations of existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant