Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Steins;Gate (Steam) #55

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Support for Steins;Gate (Steam) #55

wants to merge 6 commits into from

Conversation

casept
Copy link
Contributor

@casept casept commented Sep 8, 2024

Currently mostly just copy-paste from other games. No graphics yet, but the main menu is reached (the theme music plays).

@casept
Minor enhancements to debug logging and error handling
e887c6c
@casept
Intial work on Steins;Gate (Steam)
388e368 
Get Steins;Gate to the point where it's at the main menu
(though only the music plays, graphics are currently broken).

Much of this is copy-paste from other games and probably wrong.
@MrRevo3D
Copy link
Member

MrRevo3D commented Sep 9, 2024

Hey @casept !
Since this is the Steam version and S;G has a bunch of other versions for other consoles (like the PS3 one we already have support for and the original Xbox 360 one which is probably also different in some way) can we please rename all "sg"/"SG" references in this PR to "sghd"/"SGHD"? Just to better differentiate it from the other ones. And I know this is marked as draft but I'll leave some preliminary comments if you don't mind.

MrRevo3D
MrRevo3D requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@MrRevo3D MrRevo3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for the things I've noticed just so I don't forget about it later.

profiles/sg/game.lua Outdated
root.LayerCount = 100;
root.GameFeatures = GameFeature.Sc3VirtualMachine | GameFeature.Renderer2D | GameFeature.Input | GameFeature.Audio |
GameFeature.Video | GameFeature.DebugMenu;
-- NOTE: 1080p messes up rendering of "loading system data..." message,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1080p is correct for S;G HD. But you are reusing the system message box from C;H LCC which is a base 720p game. You can try to reuse the system message box for example from Memories Off 8 (which looks/acts pretty similar) and it should look correct.

src/profile/ui/titlemenu.cpp Outdated Show resolved Hide resolved
src/vm/vm.cpp Outdated Show resolved Hide resolved
src/vm/vm.cpp Show resolved Hide resolved
@MrRevo3D
Copy link
Member

MrRevo3D commented Sep 9, 2024

Thank you for the changes! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrRevo3D MrRevo3D MrRevo3D requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casept @MrRevo3D