-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import Issues when opening from URL in 1.7 and 2.0 #547
Comments
Why not just make a catalog-v001.xml and put it into the directory with the modules. Then when you open a module the catalog will be consulted and the local version used. I can create that catalog if you don't know how. |
To be clear this will work with a cloned repository, not by putting the URL into Protege. |
If you are going to change an IRI, change the version IRI rather than the ontology IRI |
|
I do not take this "https://raw.githubusercontent.com/CommonCoreOntology/CommonCoreOntologies/refs/heads/develop/src/cco-modules/ExtendedRelationOntology.ttl" to me an ontology IRI. I take it to be a URL that points towards an ontology with this IRI "https://www.commoncoreontologies.org/ExtendedRelationOntology". The IRI and the URL used to be identical, the problem I am pushing at for opening ontologies using the "Open by URL" protégé feature is that they are no longer identical. Furthermore, the URLs for the ontologies in 1.7 point towards 1.5. Once again, this is not a problem if the repository is cloned. |
Not sure what you mean by having each user resolve this by themselves? The ontology should be accessible from the ontology IRI or version IRI.
|
I am certain that we are talking about different things. I am pointing out two possible problems.
When you open 1.7 AllCore.ttl on the Master branch using "Open from URL..." in Protégé, it imports 1.5 from http://www.ontologyrepository.com/
|
You are right, I'm confused as to what the desired behavior is and what the problem is. |
Leaving what I take to be problem 2 aside for a moment, lets focus on the first issue. Do you ever open an ontology using the "open from URL" feature on Protégé? If not, I ask you to do an experiment. Please try to open AllCore 2.0 using the "open from URL" feature. For a second experiment, please locate the Agent Ontology on the CCO Master, which is CCO 1.7. Please open the raw file and find the import of the Information Ontology. You will see Please copy and paste the IRI of the ontology into your browser. If you look at the version IRI of the xml file you will see Therefore, when someone opens a CCO 1.7 ontology using the "open from URL", the imports are that of 1.5, not 1.7. |
What does it mean to "open a version 1.7 ontology" using the open from URL in protege. Exactly what URL are you using? |
That URL that is on GitHub that has this version IRI http://www.ontologyrepository.com/CommonCoreOntologies/Mid/2024-11-03/AgentOntology and this Base IRI |
You still seem to be missing the point that imports for 1.7 should be imported using 1.7 versionIRIs, not plain CCO IRIs. Kinds of versions:
I don't know what the redirect rules are at ontologyrepository are but if you want 1.7 to be the current ontology, you need to fix those rules so that the other ontology IRIs return 1.7 versions. OR BETTER, have 1.7 import using the 1.7 versionIRIs (and make sure those resolve) Particularly during transition times is to use my #2. Even if you do #1 it is still best practice to import using the versionIRIs |
Only the Base IRI points to an existing website. That existing website contains 1.5. |
We should probably have a phone conversation, cause we're apparently failing to communicate. I'm going out now but could talk tomorrow. |
http://www.ontologyrepository.com/CommonCoreOntologies/Mid/AgentOntology rdf:type owl:Ontology ; This is literal code from Agent Ontology 1.7. The import is not a version IRI, it is a base IRI. Am I supposed to manually resolve this when I open the ontology myself? That was not the case before 1.6 was released. |
@alanruttenberg A specific issue resulting from the issue @CarterBeauBenson mentions is that the ontology that loads from the All Core raw url from the "Master" branch (https://raw.githubusercontent.com/CommonCoreOntology/CommonCoreOntologies/refs/heads/master/src/cco-merged/AllCoreOntology.ttl), and which is labeled 1.7 in its ontology annotations, still has the 1.5 definitions. Agent, for example, is defined as
The 1.7 definition of Agent is
And this is the case for all definitions loaded from https://raw.githubusercontent.com/CommonCoreOntology/CommonCoreOntologies/refs/heads/master/src/cco-merged/AllCoreOntology.ttl |
@alanruttenberg I am free after the P&G for a teams call. I can show you what Alec and I speak of. |
CCO 1.5 was able to be opened in Protégé using the "raw" file on GitHub because the URLs for the import files resolved at the ontologyrepository.org webpage. This allowed users to view CCO in GitHub without having to clone the repository or download files.
1.7 Issue:
This method does not work correctly for 1.7. A user can open 1.7 AllCore.ttl or Agent.ttl and be mislead by the version IRI that they are viewing 1.7 when in reality, they are viewing 1.5. This is because the URLs for the imports still resolve at the ontologyrepository page that has not been updated since 1.5. Note, the only way for a user to view 1.7 using the open from URL feature is to open CommonCoreOntologiesMerged, since there are no in the file.
2.0 Issue:
This method does not work at all for 2.0 because the URLs point to commoncoreontologies.org, which is still under construction.
I understand that the preferred method of working with CCO is by cloning the repository. All core works correctly when opened from a local directory because the catalog file is automatically in the correct folder. The local method does not automatically work when trying to open a module. For example when opening the Agent Ontology, the Information Ontology fails to import. This would not be a problem if there was a catalog file for the Agent ontology in the same folder as the Agent Ontology.
That said, I think that there should still be the option for people to open 1.7 and 2.0 via the "open URL" function in Protégé.
Proposal: I suggest keeping Dev and Master Branches the way they are now, with clear instruction that one ought to clone the repository to work with it.
In addition, I suggest the creation of a third branch that is intended to be able to be opened using the "open URL" function. This would be achieved by replacing the import URL in each ontology with the resolvable GitHub raw file URL. For example, I suggest a replacement of "https://www.commoncoreontologies.org/ExtendedRelationOntology" in the Imports of the Geospatial ontology with "https://raw.githubusercontent.com/CommonCoreOntology/CommonCoreOntologies/refs/heads/develop/src/cco-modules/ExtendedRelationOntology.ttl". This would allow users to open each file from the Raw.
Once the URLs for ontologies using the commoncoreontologies.org resolve correctly, this branch should be trimmed.
The text was updated successfully, but these errors were encountered: