Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump target IDEA version to 2024.2 #104

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Bump target IDEA version to 2024.2 #104

wants to merge 2 commits into from

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Aug 7, 2024

No description provided.

@Goooler Goooler requested a review from egorikftp August 7, 2024 11:02
@egorikftp
Copy link
Member

Will this not break support for older IntelliJ versions?

@Goooler
Copy link
Member Author

Goooler commented Aug 7, 2024

The compatible version range should be

pluginConfiguration.ideaVersion {
sinceBuild = "241"
untilBuild = "242.*"
}

@Goooler
Copy link
Member Author

Goooler commented Aug 7, 2024

I verified the distribution on 2024.1.4 and 2024.2, both work well.

@Goooler
Copy link
Member Author

Goooler commented Aug 7, 2024

https://github.com/ComposeGears/Valkyrie/actions/runs/10283050259/job/28456063748?pr=104

[org.jetbrains.intellij.platform] The following plugin configuration issues were found:
- The since-build='241' is lower than the target IntelliJ Platform major version: '242'.
- The Java configuration specifies sourceCompatibility='17' but IntelliJ Platform '2024.2' requires sourceCompatibility='21'.

@Goooler
Copy link
Member Author

Goooler commented Aug 7, 2024

May hold this PR until we are ready to drop 2024.1 supports.

@egorikftp egorikftp marked this pull request as draft August 7, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants